dilim/systemd
1
0 Fork 0
mirror of https://github.com/systemd/systemd.git synced 2026-11-06 05:17:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-cgroup-util: comment bare literal arguments

Browse Source 
The argument-comments lint check fails on the check_p_g_u_u_p() calls
added in 478287a5e6, since they pass 0 and NULL without
/* code= */ and /* result= */ comments. Add them, as the
neighbouring check_p_g_u_u() calls already do.
This commit is contained in:
Lennart Poettering authored and Yu Watanabe committed 2026-11-06 12:17:43 +09:00
1 parent 7c6c0851f1
commit 8f3df1c9a9
1 file changed
+14 -14
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test-cgroup-util.c
+14 -14
View File
@@ -159,20 +159,20 @@ static void check_p_g_u_u_p(const char *path, int code, const char *result) {
}
TEST(path_get_user_unit_path) {
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service/", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service/asdf", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service/asdf", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service/asdf", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/example.slice/foobar.service", 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/example.slice/foobar.service");
check_p_g_u_u_p("/capsule.slice/capsule@test.service/app.slice/foobar.service", 0, "/capsule.slice/capsule@test.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/session-2.scope/foobar.service", 0, "/user.slice/user-1000.slice/session-2.scope/foobar.service");
check_p_g_u_u_p("sadfdsafsda", -ENXIO, NULL);
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foo###bar.service", -ENXIO, NULL);
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@.service", -ENXIO, NULL);
check_p_g_u_u_p("/system.slice/foobar.service", -ENXIO, NULL);
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service/", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service/asdf", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service/asdf", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@baz.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service/asdf", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/_cpu.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/example.slice/foobar.service", /* code= */ 0, "/user.slice/user-1000.slice/user@1000.service/app.slice/example.slice/foobar.service");
check_p_g_u_u_p("/capsule.slice/capsule@test.service/app.slice/foobar.service", /* code= */ 0, "/capsule.slice/capsule@test.service/app.slice/foobar.service");
check_p_g_u_u_p("/user.slice/user-1000.slice/session-2.scope/foobar.service", /* code= */ 0, "/user.slice/user-1000.slice/session-2.scope/foobar.service");
check_p_g_u_u_p("sadfdsafsda", -ENXIO, /* result= */ NULL);
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foo###bar.service", -ENXIO, /* result= */ NULL);
check_p_g_u_u_p("/user.slice/user-1000.slice/user@1000.service/app.slice/foobar@.service", -ENXIO, /* result= */ NULL);
check_p_g_u_u_p("/system.slice/foobar.service", -ENXIO, /* result= */ NULL);
}
static void check_p_g_s(const char *path, int code, const char *result) {