repart: Restore early generation of fstab/crypttab

Commit 15b1c33 ("repart: Generate fstab and crypttab late") moved
fstab/crypttab generation to the late stage but this introduced a regression:
it may be necessary to include fstab and crypttab into the generated partition
(e.g. with CopyFiles=). This is incompatible with 'fixate-volume-key' option as
it is impossible to capture LUKS volume key before it gets created but all the
rest should work fine.

Generate crypttab twice: early and late to capture possible changes. There's no
need to do the same for fstab for now, so keep the status quo.
This commit is contained in:
Vitaly Kuznetsov
2026-01-26 14:10:38 +01:00
parent 95a7b7d474
commit 307785960b
2 changed files with 14 additions and 8 deletions

View File

@@ -884,7 +884,9 @@
</para>
<para>Note that this setting is only taken into account when <option>--generate-crypttab=</option>
is specified on the <command>systemd-repart</command> command line.</para>
is specified on the <command>systemd-repart</command> command line. As the crypttab with the expected
hashes can only be generated after LUKS volumes are formatted, the crypttab itself cannot be put to
the generated volume.</para>
<xi:include href="version-info.xml" xpointer="v256"/></listitem>
</varlistentry>

View File

@@ -8501,7 +8501,7 @@ static bool need_crypttab(Context *context) {
return false;
}
static int context_crypttab(Context *context) {
static int context_crypttab(Context *context, bool late) {
_cleanup_(unlink_and_freep) char *t = NULL;
_cleanup_fclose_ FILE *f = NULL;
_cleanup_free_ char *path = NULL;
@@ -8544,7 +8544,7 @@ static int context_crypttab(Context *context) {
strempty(p->encrypted_volume->options));
}
r = flink_tmpfile(f, t, path, 0);
r = flink_tmpfile(f, t, path, late ? LINK_TMPFILE_REPLACE : 0);
if (r < 0)
return log_error_errno(r, "Failed to link temporary file to %s: %m", path);
@@ -10755,6 +10755,14 @@ static int run(int argc, char *argv[]) {
if (r < 0)
return r;
r = context_fstab(context);
if (r < 0)
return r;
r = context_crypttab(context, /* late= */ false);
if (r < 0)
return r;
r = context_update_verity_size(context);
if (r < 0)
return r;
@@ -10810,11 +10818,7 @@ static int run(int argc, char *argv[]) {
if (r < 0)
return r;
r = context_fstab(context);
if (r < 0)
return r;
r = context_crypttab(context);
r = context_crypttab(context, /* late= */ true);
if (r < 0)
return r;