dilim/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-05 01:21:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: tighten codex app-server policy assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-10 02:39:54 +01:00
parent 7eac2f8c77
commit eae1ffdf4a
1 changed files with 30 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
extensions/codex/src/app-server/run-attempt.test.ts
View File

@@ -4148,20 +4148,13 @@ describe("runCodexAppServerAttempt", () => {
developerInstructions: expect.stringContaining(CODEX_GPT5_BEHAVIOR_CONTRACT),
persistExtendedHistory: true,
});
expect(requests).toEqual(
expect.arrayContaining([
{
method: "turn/start",
params: expect.objectContaining({
approvalPolicy: "on-request",
approvalsReviewer: "guardian_subagent",
sandboxPolicy: { type: "dangerFullAccess" },
serviceTier: "priority",
model: "gpt-5.4-codex",
}),
},
]),
);
const turnRequest = requests.find((request) => request.method === "turn/start");
const turnRequestParams = turnRequest?.params as Record<string, unknown> | undefined;
expect(turnRequestParams?.approvalPolicy).toBe("on-request");
expect(turnRequestParams?.approvalsReviewer).toBe("guardian_subagent");
expect(turnRequestParams?.sandboxPolicy).toEqual({ type: "dangerFullAccess" });
expect(turnRequestParams?.serviceTier).toBe("priority");
expect(turnRequestParams?.model).toBe("gpt-5.4-codex");
});
it("passes current Codex service tier request values through app-server resume and turn requests", async () => {
@@ -4184,9 +4177,11 @@ describe("runCodexAppServerAttempt", () => {
await run;
const resumeRequest = requests.find((request) => request.method === "thread/resume");
expect(resumeRequest?.params).toEqual(expect.objectContaining({ serviceTier: "priority" }));
const resumeRequestParams = resumeRequest?.params as Record<string, unknown> | undefined;
expect(resumeRequestParams?.serviceTier).toBe("priority");
const turnRequest = requests.find((request) => request.method === "turn/start");
expect(turnRequest?.params).toEqual(expect.objectContaining({ serviceTier: "priority" }));
const turnRequestParams = turnRequest?.params as Record<string, unknown> | undefined;
expect(turnRequestParams?.serviceTier).toBe("priority");
});
it("keys plugin app inventory by websocket credentials without exposing them", () => {
@@ -4255,27 +4250,26 @@ describe("runCodexAppServerAttempt", () => {
developerInstructions: expect.stringContaining(CODEX_GPT5_BEHAVIOR_CONTRACT),
persistExtendedHistory: true,
});
expect(
buildTurnStartParams(params, { threadId: "thread-1", cwd: "/tmp/workspace", appServer }),
).toEqual(
expect.objectContaining({
threadId: "thread-1",
cwd: "/tmp/workspace",
const turnParams = buildTurnStartParams(params, {
threadId: "thread-1",
cwd: "/tmp/workspace",
appServer,
});
expect(turnParams.threadId).toBe("thread-1");
expect(turnParams.cwd).toBe("/tmp/workspace");
expect(turnParams.model).toBe("gpt-5.4-codex");
expect(turnParams.approvalPolicy).toBe("on-request");
expect(turnParams.approvalsReviewer).toBe("guardian_subagent");
expect(turnParams.sandboxPolicy).toEqual({ type: "dangerFullAccess" });
expect(turnParams.serviceTier).toBe("flex");
expect(turnParams.collaborationMode).toEqual({
mode: "default",
settings: {
model: "gpt-5.4-codex",
approvalPolicy: "on-request",
approvalsReviewer: "guardian_subagent",
sandboxPolicy: { type: "dangerFullAccess" },
serviceTier: "flex",
collaborationMode: {
mode: "default",
settings: {
model: "gpt-5.4-codex",
reasoning_effort: "medium",
developer_instructions: null,
},
},
}),
);
reasoning_effort: "medium",
developer_instructions: null,
},
});
});
it("uses turn-scoped collaboration instructions for heartbeat Codex turns", () => {