dilim/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-09 03:22:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sandbox): clamp unsafe stat sizes

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-29 09:43:10 -04:00
parent 8b12be05ec
commit d9db23dc2f
3 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/agents/sandbox/fs-bridge-stat-parse.ts
View File

@@ -1,10 +1,12 @@
import { parseStrictNonNegativeInteger } from "../../infra/parse-finite-number.js";
export function parseSandboxStatSize(value: string | undefined): number {
const raw = value ?? "0";
if (!/^\d+$/.test(raw)) {
return 0;
const parsed = parseStrictNonNegativeInteger(raw);
if (parsed !== undefined) {
return parsed;
}
const size = Number(raw);
return Number.isFinite(size) ? size : 0;
return /^\d+$/.test(raw) ? Number.MAX_SAFE_INTEGER : 0;
}
export function parseSandboxStatMtimeMs(value: string | undefined): number {

6
src/agents/sandbox/fs-bridge.anchored-ops.test.ts
View File

@@ -217,7 +217,7 @@ describe("sandbox fs bridge anchored ops", () => {
});
});
it("does not accept partial stat size output", async () => {
it("saturates unsafe stat size output", async () => {
await withTempDir("openclaw-fs-bridge-stat-parse-", async (stateDir) => {
const workspaceDir = path.join(stateDir, "workspace");
await fs.mkdir(workspaceDir, { recursive: true });
@@ -228,7 +228,7 @@ describe("sandbox fs bridge anchored ops", () => {
return dockerExecResult(`${getDockerArg(args, 1)}\n`);
}
if (script.includes('stat -c "%F|%s|%y"')) {
return dockerExecResult("regular file|12oops|not-a-date\n");
return dockerExecResult("regular file|9007199254740992|not-a-date\n");
}
return dockerExecResult("");
});
@@ -242,7 +242,7 @@ describe("sandbox fs bridge anchored ops", () => {
await expect(bridge.stat({ filePath: "note.txt" })).resolves.toMatchObject({
type: "file",
size: 0,
size: Number.MAX_SAFE_INTEGER,
mtimeMs: 0,
});
});

6
src/agents/sandbox/remote-fs-bridge.test.ts
View File

@@ -182,7 +182,7 @@ describe("remote sandbox fs bridge", () => {
},
);
it("does not return NaN or partial values for malformed stat output", async () => {
it("saturates unsafe stat size output without returning NaN", async () => {
await withTempDir("openclaw-remote-fs-bridge-stat-", async (stateDir) => {
const workspaceDir = path.join(stateDir, "workspace");
await fs.mkdir(workspaceDir, { recursive: true });
@@ -209,7 +209,7 @@ describe("remote sandbox fs bridge", () => {
}
if (command.script.includes('stat -c "%F|%s|%y"')) {
return {
stdout: Buffer.from("regular file|12oops|not-a-date\n"),
stdout: Buffer.from("regular file|9007199254740992|not-a-date\n"),
stderr: Buffer.alloc(0),
code: 0,
};
@@ -227,7 +227,7 @@ describe("remote sandbox fs bridge", () => {
await expect(bridge.stat({ filePath: "note.txt" })).resolves.toEqual({
type: "file",
size: 0,
size: Number.MAX_SAFE_INTEGER,
mtimeMs: 0,
});
});