dilim/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-12 22:17:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(memory-host): reject queued worker requests on shutdown (#102451)

Browse Source 
* fix(memory-host): reject queued worker requests on shutdown

* fix(memory-host): settle queued requests on shutdown

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
QiuYuang
2026-07-09 16:26:05 +08:00
committed by GitHub
parent c96163b6ca
commit d5a31888ed
2 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/memory-host-sdk/src/host/embeddings-worker.ts
View File

@@ -333,6 +333,13 @@ class LocalEmbeddingWorkerClient {
if (!child) {
return;
}
this.rejectPending(
createLocalEmbeddingWorkerFailureError({
message: "Local embedding worker exited unexpectedly (shutdown)",
code: LOCAL_EMBEDDING_WORKER_ERROR_CODES.exited,
reason: "exit",
}),
);
if (child.connected) {
child.disconnect();
}

20
packages/memory-host-sdk/src/host/embeddings.test.ts
View File

@@ -441,7 +441,7 @@ process.on("message", (message) => {
await expect(provider.close?.()).resolves.toBeUndefined();
});
it("terminates the worker when close runs behind a pending request", async () => {
it("rejects pending and queued requests when closing a busy worker", async () => {
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-local-embedding-worker-"));
const workerScript = path.join(tempDir, "worker.cjs");
const embedStartedPath = path.join(tempDir, "embed-started");
@@ -478,8 +478,7 @@ process.on("message", (message) => {
{ workerScriptPath: workerScript },
);
const embedPromise = provider.embedQuery("stuck");
const embedError = embedPromise.then(
const firstEmbedError = provider.embedQuery("first").then(
() => undefined,
(err: unknown) => err,
);
@@ -494,6 +493,16 @@ process.on("message", (message) => {
})
.toBe(true);
const queuedEmbedResult = Promise.race([
provider.embedQuery("queued").then(
() => "resolved" as const,
(err: unknown) => err,
),
new Promise<"timeout">((resolve) => {
setTimeout(() => resolve("timeout"), 1_000);
}),
]);
const closePromise = provider.close?.() ?? Promise.resolve();
const closeResult = await Promise.race([
closePromise.then(() => "closed" as const),
@@ -503,7 +512,10 @@ process.on("message", (message) => {
]);
expect(closeResult).toBe("closed");
await expect(embedError).resolves.toMatchObject({
await expect(firstEmbedError).resolves.toMatchObject({
code: LOCAL_EMBEDDING_WORKER_ERROR_CODES.exited,
});
await expect(queuedEmbedResult).resolves.toMatchObject({
code: LOCAL_EMBEDDING_WORKER_ERROR_CODES.exited,
});
});