dilim/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-06-24 10:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): validate DMG resize slack

Browse Source
This commit is contained in:
Vincent Koc
2026-06-23 09:50:46 +02:00
parent da32c7fe53
commit d0f591893b
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/create-dmg.sh
View File

@@ -84,10 +84,20 @@ require_positive_integer() {
fi
}
require_nonnegative_integer() {
local name="$1"
local raw="$2"
if [[ ! "$raw" =~ ^(0|[1-9][0-9]*)$ || "${#raw}" -gt 9 ]]; then
echo "Error: $name must be a finite non-negative integer: '$raw'" >&2
exit 1
fi
}
require_integer_list DMG_WINDOW_BOUNDS "$DMG_WINDOW_BOUNDS" 4
require_integer_list DMG_APP_POS "$DMG_APP_POS" 2
require_integer_list DMG_APPS_POS "$DMG_APPS_POS" 2
require_positive_integer DMG_ICON_SIZE "$DMG_ICON_SIZE"
require_nonnegative_integer DMG_EXTRA_SECTORS "$DMG_EXTRA_SECTORS"
to_applescript_list4() {
local raw="$1"

12
test/scripts/create-dmg.test.ts
View File

@@ -195,6 +195,18 @@ describe("create-dmg plist validation", () => {
expect(script).not.toContain('tell application "Finder" to close every window');
});
it("fails malformed DMG resize slack before creating images", () => {
const script = readFileSync(scriptPath, "utf8");
const validationBlock = script.slice(
script.indexOf("require_integer_list()"),
script.indexOf('to_applescript_list4()'),
);
expect(validationBlock).toContain("require_nonnegative_integer()");
expect(validationBlock).toContain('require_nonnegative_integer DMG_EXTRA_SECTORS "$DMG_EXTRA_SECTORS"');
expect(validationBlock).toContain("must be a finite non-negative integer");
});
it.runIf(process.platform === "darwin")(
"fails before hdiutil when required plist keys are missing",
() => {