test: tighten slack outbound adapter assertions

This commit is contained in:
Shakker
2026-05-11 03:25:00 +01:00
parent b4b4503ff3
commit 7430475044

View File

@@ -50,40 +50,35 @@ describe("slackOutbound", () => {
});
expect(sendMessageSlackMock).toHaveBeenCalledTimes(3);
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(
1,
"C123",
"",
expect.objectContaining({
cfg,
mediaUrl: "https://example.com/1.png",
mediaLocalRoots: ["/tmp/workspace"],
}),
);
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(
2,
"C123",
"",
expect.objectContaining({
cfg,
mediaUrl: "https://example.com/2.png",
mediaLocalRoots: ["/tmp/workspace"],
}),
);
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(
3,
"C123",
"final text",
expect.objectContaining({
cfg,
blocks: [
{
type: "section",
text: { type: "mrkdwn", text: "Block body" },
},
],
}),
);
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(1, "C123", "", {
cfg,
threadTs: undefined,
accountId: "default",
mediaUrl: "https://example.com/1.png",
mediaAccess: undefined,
mediaLocalRoots: ["/tmp/workspace"],
mediaReadFile: undefined,
});
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(2, "C123", "", {
cfg,
threadTs: undefined,
accountId: "default",
mediaUrl: "https://example.com/2.png",
mediaAccess: undefined,
mediaLocalRoots: ["/tmp/workspace"],
mediaReadFile: undefined,
});
expect(sendMessageSlackMock).toHaveBeenNthCalledWith(3, "C123", "final text", {
cfg,
threadTs: undefined,
accountId: "default",
blocks: [
{
type: "section",
text: { type: "mrkdwn", text: "Block body" },
},
],
});
expect(result).toEqual({ channel: "slack", messageId: "m-final" });
});
@@ -105,14 +100,12 @@ describe("slackOutbound", () => {
accountId: "default",
});
expect(sendMessageSlackMock).toHaveBeenCalledWith(
"C123",
"fallback text",
expect.objectContaining({
cfg,
blocks: [{ type: "divider" }],
}),
);
expect(sendMessageSlackMock).toHaveBeenCalledWith("C123", "fallback text", {
cfg,
threadTs: undefined,
accountId: "default",
blocks: [{ type: "divider" }],
});
expect(result).toEqual({ channel: "slack", messageId: "m-blocks" });
});
@@ -136,13 +129,12 @@ describe("slackOutbound", () => {
accountId: "default",
});
expect(sendMessageSlackMock).toHaveBeenCalledWith(
"C123",
"fallback text",
expect.objectContaining({
threadTs: "1712345678.123456",
}),
);
expect(sendMessageSlackMock).toHaveBeenCalledWith("C123", "fallback text", {
cfg,
threadTs: "1712345678.123456",
accountId: "default",
blocks: [{ type: "divider" }],
});
});
it("does not thread payloads without a valid Slack thread timestamp", async () => {
@@ -165,12 +157,11 @@ describe("slackOutbound", () => {
accountId: "default",
});
expect(sendMessageSlackMock).toHaveBeenCalledWith(
"C123",
"fallback text",
expect.objectContaining({
threadTs: undefined,
}),
);
expect(sendMessageSlackMock).toHaveBeenCalledWith("C123", "fallback text", {
cfg,
threadTs: undefined,
accountId: "default",
blocks: [{ type: "divider" }],
});
});
});