dilim/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-08 02:52:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(agents): drop duplicate gateway allowlist test export

Browse Source
This commit is contained in:
Vincent Koc
2026-06-19 20:01:57 +08:00
parent 99e69e16b7
commit 56c5630107
2 changed files with 9 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/agents/tools/gateway-tool-guard-coverage.test.ts
View File

@@ -1,10 +1,7 @@
// Gateway config mutation guard coverage keeps agent-driven config edits inside
// the documented low-risk allowlist.
import { describe, expect, it } from "vitest";
import {
ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST,
assertGatewayConfigMutationAllowedForTest,
} from "./gateway-tool.js";
import { assertGatewayConfigMutationAllowedForTest } from "./gateway-tool.js";
function expectBlocked(
currentConfig: Record<string, unknown>,
@@ -59,23 +56,6 @@ function expectAllowedApply(
}
describe("gateway config mutation guard coverage", () => {
it("keeps a narrow allowlist of agent-tunable config paths", () => {
// This list is the contract between the public gateway tool and protected
// operator-owned config surfaces.
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).not.toContain("agents.defaults.promptOverlays");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).not.toContain("agents.defaults.model");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("agents.defaults.subagents.thinking");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("agents.list[].id");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("agents.list[].model");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("agents.list[].subagents.thinking");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("channels.*.requireMention");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("messages.visibleReplies");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain("messages.groupChat.visibleReplies");
expect(ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST).toContain(
"messages.groupChat.unmentionedInbound",
);
});
it("blocks global prompt overlay edits via config.patch", () => {
expectBlocked(
{ agents: { defaults: { promptOverlays: { gpt5: { personality: "off" } } } } },
@@ -167,7 +147,10 @@ describe("gateway config mutation guard coverage", () => {
{
messages: {
visibleReplies: "automatic",
groupChat: { visibleReplies: "automatic" },
groupChat: {
visibleReplies: "automatic",
unmentionedInbound: "user_request",
},
},
},
);
@@ -181,7 +164,10 @@ describe("gateway config mutation guard coverage", () => {
{
messages: {
visibleReplies: "message_tool",
groupChat: { visibleReplies: "automatic" },
groupChat: {
visibleReplies: "automatic",
unmentionedInbound: "room_event",
},
},
},
);

3
src/agents/tools/gateway-tool.ts
View File

@@ -79,9 +79,6 @@ const ALLOWED_GATEWAY_CONFIG_PATHS = [
"messages.groupChat.unmentionedInbound",
] as const;
/** @internal Exposed for regression tests only; do not import from runtime code. */
export const ALLOWED_GATEWAY_CONFIG_PATHS_FOR_TEST = ALLOWED_GATEWAY_CONFIG_PATHS;
/** @internal Exposed for regression tests only; do not import from runtime code. */
export function assertGatewayConfigMutationAllowedForTest(params: {
action: "config.apply" | "config.patch";