dilim/ninja
1
0
Fork 0
mirror of https://github.com/ninja-build/ninja.git synced 2026-08-08 00:52:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable long word wrapping entirely in comments.

Browse Source 
As pointed out by nico, we should unconditionally disable breaking of
long words in comments. It is unlikely long words that are in comments
should be split (like pathnames).
This commit is contained in:
Alex Vallée
2015-11-27 16:09:34 -05:00
parent 8c18cf97ff
commit 97e96284a3
2 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
misc/ninja_syntax.py
View File

@@ -22,10 +22,8 @@ class Writer(object):
self.output.write('\n')
def comment(self, text, has_path=False):
args = {}
if has_path:
args['break_long_words'] = args['break_on_hyphens'] = False
for line in textwrap.wrap(text, self.width - 2, **args):
for line in textwrap.wrap(text, self.width - 2, break_long_words=False,
break_on_hyphens=False):
self.output.write('# ' + line + '\n')
def variable(self, key, value, indent=0):

7
misc/ninja_syntax_test.py
View File

@@ -46,13 +46,8 @@ class TestLineWordWrap(unittest.TestCase):
self.out.getvalue())
def test_comment_wrap(self):
# We should wrap the comments
self.n.comment('Hello there')
self.assertEqual('# Hello\n# there\n', self.out.getvalue())
def test_comment_wrap_filename(self):
# Filenames shoud not be wrapped
self.n.comment('Hello /usr/local/build-tools/bin', has_path=True)
self.n.comment('Hello /usr/local/build-tools/bin')
self.assertEqual('# Hello\n# /usr/local/build-tools/bin\n',
self.out.getvalue())