dilim/ninja
1
0
Fork 0
mirror of https://github.com/ninja-build/ninja.git synced 2026-06-30 19:58:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixup! fixup! fixup! Fix spurious rebuilds for phony targets with validations

Browse Source
This commit is contained in:
Neri Marschik
2026-02-16 13:59:34 +09:00
parent 43aa6e3a34
commit 03ec8c658e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/graph.cc
View File

@@ -285,8 +285,8 @@ bool DependencyScan::RecomputeOutputDirty(const Edge* edge,
if (edge->is_phony()) {
// Phony edges don't write any output. Outputs are only dirty if
// there are no inputs or validations and we're missing the output.
// If a phony target has inputs or validations, they are used for dirty
// calculation instead of this fallback.
// If a phony target has inputs or validations, or the output exists,
// they are used for dirty calculation instead of this fallback.
if (edge->inputs_.empty() && edge->validations_.empty() &&
!output->exists()) {
explanations_.Record(