dilim/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-08-09 09:33:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

integration/build: TestBuildUncleanTarFilenames use path within root

Browse Source 
This test was added in f6c8266afd ("Fix
cache invalidation for tar with "unclean" paths") and used "../foo"
as an unclean archive path.

Replace it with "dir/../foo", which exercises the same normalization
logic while remaining within the archive root.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2026-07-20 14:40:08 +02:00
parent 11ee7e07df
commit c32088a23e
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
integration/build/build_test.go
View File

@@ -375,7 +375,12 @@ RUN cat somefile`
assert.Check(t, is.Contains(img.Config.Env, "bar=baz"))
}
// #35403 #36122
// TestBuildUncleanTarFilenames is a regression test for cache invalidation
// with non-canonical, in-context archive paths.
//
// See:
// - https://github.com/moby/moby/issues/35403
// - https://github.com/moby/moby/issues/36122
func TestBuildUncleanTarFilenames(t *testing.T) {
skip.If(t, testEnv.DaemonInfo.OSType == "windows", "FIXME")
@@ -391,7 +396,7 @@ COPY bar /
buf := bytes.NewBuffer(nil)
w := tar.NewWriter(buf)
writeTarRecord(t, w, "Dockerfile", dockerfile)
writeTarRecord(t, w, "../foo", "foocontents0")
writeTarRecord(t, w, "dir/../foo", "foocontents0")
writeTarRecord(t, w, "/bar", "barcontents0")
err := w.Close()
assert.NilError(t, err)
@@ -413,7 +418,7 @@ COPY bar /
buf = bytes.NewBuffer(nil)
w = tar.NewWriter(buf)
writeTarRecord(t, w, "Dockerfile", dockerfile)
writeTarRecord(t, w, "../foo", "foocontents1")
writeTarRecord(t, w, "dir/../foo", "foocontents1")
writeTarRecord(t, w, "/bar", "barcontents1")
err = w.Close()
assert.NilError(t, err)