mirror of
https://github.com/moby/moby.git
synced 2026-08-09 09:33:50 +00:00
Merge pull request #52699 from vvoland/pr-template
github: Improve Pull Request template
This commit is contained in:
39
.github/PULL_REQUEST_TEMPLATE.md
vendored
39
.github/PULL_REQUEST_TEMPLATE.md
vendored
@@ -2,35 +2,36 @@
|
||||
Please make sure you've read and understood our contributing guidelines;
|
||||
https://github.com/moby/moby/blob/master/CONTRIBUTING.md
|
||||
|
||||
** Make sure all your commits include a signature generated with `git commit -s` **
|
||||
Make sure commits are signed off (`git commit -s`) with your real name.
|
||||
|
||||
For additional information on our contributing process, read our contributing
|
||||
guide https://github.com/moby/moby/blob/master/docs/contributing/
|
||||
If the PR relates to an existing issue or PR, mention it at the top:
|
||||
|
||||
If this is a bug fix, make sure your description includes "fixes #xxxx", or
|
||||
"closes #xxxx"
|
||||
|
||||
Please provide the following information:
|
||||
- Fixes: https://github.com/moby/moby/issues/12345678
|
||||
- Replaces: https://github.com/moby/moby/pull/12345678
|
||||
- Follow up to: https://github.com/moby/moby/pull/12345678
|
||||
- Related to: https://github.com/moby/moby/issues/12345678
|
||||
-->
|
||||
|
||||
**- What I did**
|
||||
## Summary
|
||||
|
||||
**- How I did it**
|
||||
## Release notes (optional)
|
||||
|
||||
**- How to verify it**
|
||||
|
||||
**- Human readable description for the release notes**
|
||||
<!--
|
||||
Write a short (one line) summary that describes the changes in this
|
||||
pull request for inclusion in the changelog.
|
||||
It must be placed inside the below triple backticks section.
|
||||
One-sentence user-facing release note.
|
||||
Leave empty if the change is not changelog-worthy.
|
||||
Use present tense and imperative tone.
|
||||
|
||||
NOTE: Only fill this section if changes introduced in this PR are user-facing.
|
||||
The PR must have a relevant impact/ label.
|
||||
Good:
|
||||
- Fix a panic when running `docker top` on a non-running Windows container.
|
||||
- Don't print warnings in `docker info` for broken symlinks in CLI plugin directories.
|
||||
|
||||
Bad:
|
||||
- Refactor test TestFooWithBar
|
||||
- Fixed a panic when running docker top
|
||||
-->
|
||||
|
||||
```markdown changelog
|
||||
|
||||
```
|
||||
|
||||
**- A picture of a cute animal (not mandatory but encouraged)**
|
||||
|
||||
## A picture of a cute animal (not mandatory but encouraged)
|
||||
|
||||
Reference in New Issue
Block a user