Merge pull request #46181 from vvoland/tests-volumemounts-nilerror

test/volume: Replace Check with NilError where suitable
This commit is contained in:
Sebastiaan van Stijn
2023-08-10 13:12:28 +02:00
committed by GitHub
5 changed files with 6 additions and 5 deletions

View File

@@ -220,7 +220,7 @@ func TestLCOWParseMountRawSplit(t *testing.T) {
return
}
assert.Check(t, err)
assert.NilError(t, err)
assert.Check(t, is.Equal(m.Destination, tc.expDest))
assert.Check(t, is.Equal(m.Source, tc.expSource))
assert.Check(t, is.Equal(m.Name, tc.expName))

View File

@@ -188,7 +188,7 @@ func TestLinuxParseMountRawSplit(t *testing.T) {
return
}
assert.Check(t, err)
assert.NilError(t, err)
assert.Check(t, is.Equal(m.Destination, tc.expDest))
assert.Check(t, is.Equal(m.Source, tc.expSource))
assert.Check(t, is.Equal(m.Name, tc.expName))

View File

@@ -82,7 +82,8 @@ func TestParseMountSpec(t *testing.T) {
tc := tc
t.Run("", func(t *testing.T) {
mp, err := parser.ParseMountSpec(tc.input)
assert.Check(t, err)
assert.NilError(t, err)
assert.Check(t, is.Equal(mp.Type, tc.expected.Type))
assert.Check(t, is.Equal(mp.Destination, tc.expected.Destination))
assert.Check(t, is.Equal(mp.Source, tc.expected.Source))

View File

@@ -234,7 +234,7 @@ func TestWindowsParseMountRawSplit(t *testing.T) {
return
}
assert.Check(t, err)
assert.NilError(t, err)
assert.Check(t, is.Equal(m.Destination, tc.expDest))
assert.Check(t, is.Equal(m.Source, tc.expSource))
assert.Check(t, is.Equal(m.Name, tc.expName))

View File

@@ -379,7 +379,7 @@ func setupTest(t *testing.T) (*VolumeStore, func()) {
}
s, err := NewStore(dir, volumedrivers.NewStore(nil))
assert.Check(t, err)
assert.NilError(t, err)
return s, func() {
s.Shutdown()
cleanup()