dilim/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-08-08 00:52:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

libnetwork/types: TestUtilGetHostPartIP: use gotest.tools, table-tests

Browse Source 
Also rename the test to TestGetHostPartIP, removing "Util" from  the name.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-01-21 16:01:14 +01:00
parent 9e11ea9287
commit 06ae35afb9
1 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
libnetwork/types/types_test.go
View File

@@ -129,8 +129,8 @@ func TestCompareIPMask(t *testing.T) {
}
}
func TestUtilGetHostPartIP(t *testing.T) {
input := []struct {
func TestGetHostPartIP(t *testing.T) {
tests := []struct {
ip net.IP
mask net.IPMask
host net.IP
@@ -163,28 +163,25 @@ func TestUtilGetHostPartIP(t *testing.T) {
},
}
for _, i := range input {
h, err := GetHostPartIP(i.ip, i.mask)
if err != nil {
t.Fatal(err)
}
if !i.host.Equal(h) {
t.Fatalf("Failed to return expected host ip. Expected: %s. Got: %s", i.host, h)
}
for _, tc := range tests {
h, err := GetHostPartIP(tc.ip, tc.mask)
assert.NilError(t, err)
assert.Assert(t, tc.host.Equal(h), "Failed to return expected host ip. Expected: %s. Got: %s", tc.host, h)
}
const expectedErr = "cannot compute host portion ip address because ip and mask are not compatible"
// ip as v6 and mask as v4 are not compatible
if _, err := GetHostPartIP(net.ParseIP("2001:DB8:2002:2001:FFFF:ABCD:EEAB:00CD"), []byte{0xff, 0xff, 0xff, 0}); err == nil {
t.Fatalf("Unexpected success")
}
_, err := GetHostPartIP(net.ParseIP("2001:DB8:2002:2001:FFFF:ABCD:EEAB:00CD"), []byte{0xff, 0xff, 0xff, 0})
assert.Check(t, is.ErrorContains(err, expectedErr))
// ip as v4 and non conventional mask
if _, err := GetHostPartIP(net.ParseIP("173.32.4.5"), []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xff, 0xff, 0xff, 0}); err == nil {
t.Fatalf("Unexpected success")
}
_, err = GetHostPartIP(net.ParseIP("173.32.4.5"), []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xff, 0xff, 0xff, 0})
assert.Check(t, is.ErrorContains(err, expectedErr))
// ip as v4 and non conventional mask
if _, err := GetHostPartIP(net.ParseIP("173.32.4.5"), []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xff, 0xff, 0xff, 0xff, 0xff, 0}); err == nil {
t.Fatalf("Unexpected success")
}
_, err = GetHostPartIP(net.ParseIP("173.32.4.5"), []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xff, 0xff, 0xff, 0xff, 0xff, 0})
assert.Check(t, is.ErrorContains(err, expectedErr))
}
func TestUtilGetBroadcastIP(t *testing.T) {