dilim/homeassistant-rental-control
1
0
Fork 0
mirror of https://github.com/tykeal/homeassistant-rental-control.git synced 2026-06-24 08:47:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Docs: fix self-review findings

Browse Source 
Add §1.3 to spec exclusions alongside §1.2.
Align §4.1 and §6.1 severity labels between
headings and summary table.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
This commit is contained in:
Andrew Grimberg
2026-03-10 10:12:45 -07:00
parent aab4d8a0e4
commit d799b7f7c2
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
code-reviews/20260310-rc_review.md
View File

@@ -208,7 +208,7 @@ linter, not pylint. These are inert comments that add noise.
## 4. Security Considerations
### 4.1 MD5 for UUID Generation (Low)
### 4.1 MD5 for UUID Generation (Informational)
`util.py:gen_uuid()` uses `hashlib.md5()` to generate deterministic UUIDs.
While this is not a security-sensitive context (it's generating stable
@@ -372,12 +372,12 @@ should be `"""Rental Control EventOverrides."""`
| 3.4 | Unusual `isinstance(..., type(None))` | Low | Style |
| 3.5 | Stale "temporary" comment | Low | Cleanup |
| 3.6 | Inert pylint disable comments | Low | Cleanup |
| 4.1 | MD5 for UUID (informational only) | Low | Security |
| 4.1 | MD5 for UUID generation | Informational | Security |
| 4.2 | `random` for door codes (acceptable) | Low | Security |
| 5.1 | Coverage gaps in Keymaster service calls | Medium | Testing |
| 5.2 | No network error tests | Medium | Testing |
| 5.3 | `CONF_MAX_MISSES` not in config flow | Low | Config |
| 6.1 | Version 0.0.0 everywhere | Info | Packaging |
| 6.1 | Version 0.0.0 everywhere | Informational | Packaging |
| 6.2 | Empty `CONFIG_SCHEMA` | Low | Cleanup |
| 6.3 | Synchronous `setup()` function | Low | Modernization |
| 7.1 | Legacy HANDLERS.register decorator | Low | Modernization |

5
specs/002-code-health/spec.md
View File

@@ -330,8 +330,9 @@ The following items from the code review are **explicitly out of scope**:
- **Coordinator base class migration** (review §1.1): Migrating to the
platform's built-in data update coordinator is a major architectural
change requiring its own specification.
- **Coordinator class extraction / refactoring** (review §1.2): Breaking
the coordinator into smaller classes is a separate refactoring effort.
- **Coordinator class extraction / refactoring** (review §1.2, §1.3):
Breaking the coordinator into smaller classes or shorter methods is a
separate refactoring effort.
- **UUID generation algorithm change** (review §4.1): Changing the hash
function would break all existing entity IDs for current users.
- **Door code random number generator change** (review §4.2): The