MrJack
f3edb83df4
Make golangci-lint happy
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 14:46:55 +02:00
MrJack
94a3315f4d
Added missing import
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:41:49 +02:00
MrJack
500f02d597
Readded "unicode/utf8"
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:58 +02:00
MrJack
f1ede7c9c1
Potential fix for pull request finding
...
If the CLI-side description validation is removed, the unicode/utf8 import becomes unused and should also be dropped.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:58 +02:00
MrJack
4fcc4e4b3d
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:58 +02:00
MrJack
91520a7806
refactor(rollback): validate description length before cluster reachability check
...
Move description length validation to the beginning of Run(), before
IsReachable(), so programmatic callers get an immediate validation
error instead of a potentially misleading cluster reachability failure.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:58 +02:00
MrJack
e73dfab5fb
refactor(test): reuse existing rollback.txt golden file
...
Remove duplicate rollback-with-description.txt fixture that had
identical content to rollback.txt.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:57 +02:00
MrJack
b177a8e906
Removed extra space in rollback-with-description.txt
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:57 +02:00
MrJack
a92611c202
Enhance rune count in pkg/cmd/rollback.go and pkg/action/rollback.go
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:57 +02:00
MrJack
8a34f3b7b4
Use rune count to count properly multi-byte UTF-8 characters
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:57 +02:00
MrJack
cb91040c44
Enhanced rollback description length
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:55 +02:00
MrJack
e69e424ab1
Changed if construction
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:34 +02:00
MrJack
b606955f09
Set 256 as limit for maxDescriptionLength. 256 comes from MAX value for key and value
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:34 +02:00
MrJack
f8180e6de4
feat(rollback): add --description flag to provide rollback reason
...
Add a new --description flag to the helm rollback command that allows
users to specify a custom description explaining why the rollback was
performed. This description is stored in the release metadata.
Changes:
- Add Description field to the Rollback action struct
- Add --description flag to the rollback CLI command
- Add 512 character limit validation for the description
- Default to 'Rollback to <version>' when no description is provided
The description flag is optional and follows the same pattern used by
the install and upgrade commands.
Closes #XXXX
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com >
2026-07-27 09:01:31 +02:00
Terry Howe
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
2026-07-24 12:03:52 -06:00
Matthieu MOREL
622f16b37f
Update resource_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 19:06:05 +02:00
Matthieu MOREL
61d99a8bdb
Update labels_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 18:53:45 +02:00
Matthieu MOREL
532eabf88a
Update chartrepo_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 18:47:43 +02:00
Matthieu MOREL
bfca0688b1
Update show_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 18:45:58 +02:00
Matthieu MOREL
b59dfd3901
Update rollback_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 18:44:53 +02:00
Matthieu MOREL
a27f3a0620
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 18:19:56 +02:00
Terry Howe
e29e06e97d
Merge pull request #32466 from mmorel-35/testify-assertions-pkg-2
...
chore(pkg): refactor: finer tests conversions to testify part 2
2026-07-24 08:11:31 -06:00
Terry Howe
b152447a15
Merge pull request #32465 from mmorel-35/testify-assertions-internal-1
...
chore(internal): refactor: finer tests conversions to testify part 1
2026-07-24 08:11:25 -06:00
Terry Howe
c994f2a36a
Merge pull request #32464 from mmorel-35/testify-assertions-pkg-1
...
chore(pkg): refactor: finer tests conversions to testify part 1
2026-07-24 08:11:19 -06:00
Matthieu MOREL
828d01a878
chore(pkg): refactor: finer tests conversions to testify part 1
...
refactor: finer tests conversions to testify in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 14:20:03 +02:00
Matthieu MOREL
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 14:18:15 +02:00
Matthieu MOREL
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 13:24:06 +02:00
Matthieu MOREL
5142ca8ddc
chore(internal): refactor: finer tests conversions to testify part 1
...
#### Description
refactor: finer tests conversions to testify in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-07-24 13:24:06 +02:00
dependabot[bot]
8f74dce6ba
chore(deps): bump the k8s-io group across 1 directory with 7 updates ( #32459 )
...
Bumps the k8s-io group with 4 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api ), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl ).
Updates `k8s.io/api` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/api/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apiextensions-apiserver` from 0.36.2 to 0.36.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apimachinery` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apiserver` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/cli-runtime` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/client-go` from 0.36.2 to 0.36.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/kubectl` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.36.2...v0.36.3 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-24 04:40:32 -06:00
dependabot[bot]
050d3e99b9
chore(deps): bump ossf/scorecard-action in the github-actions group ( #32458 )
...
Bumps the github-actions group with 1 update: [ossf/scorecard-action](https://github.com/ossf/scorecard-action ).
Updates `ossf/scorecard-action` from 2.4.3 to 2.4.4
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](4eaacf0543...2d1146689b )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-version: 2.4.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-24 04:32:02 -06:00
Robert Sirchia
39231d01e1
Merge pull request #32435 from mmorel-35/testifylint-manual-assert-pkg-19
...
chore(pkg): refactor: convert tests to testify assert/require part 19
2026-07-23 12:19:45 -04:00
Terry Howe
f65e3b72b0
Merge pull request #32438 from mmorel-35/testifylint-manual-assert-pkg-22
...
chore(pkg): refactor: convert tests to testify assert/require part 22
2026-07-22 14:12:54 -06:00
Terry Howe
e5378ad47e
Merge pull request #32437 from mmorel-35/testifylint-manual-assert-pkg-21
...
chore(pkg): refactor: convert tests to testify assert/require part 21
2026-07-22 14:12:14 -06:00
Terry Howe
76bf75c956
Merge pull request #32436 from mmorel-35/testifylint-manual-assert-pkg-20
...
chore(pkg): refactor: convert tests to testify assert/require part 20
2026-07-22 14:11:38 -06:00
Terry Howe
bfb074a601
Merge pull request #32434 from mmorel-35/testifylint-manual-assert-pkg-18
...
chore(pkg): refactor: convert tests to testify assert/require part 18
2026-07-22 14:09:08 -06:00
Terry Howe
54b915e38a
Merge pull request #32433 from mmorel-35/testifylint-manual-assert-pkg-17
...
chore(pkg): refactor: convert tests to testify assert/require part 17
2026-07-22 14:08:36 -06:00
Terry Howe
d8a4a8287b
Merge pull request #32432 from mmorel-35/testifylint-manual-assert-pkg-16
...
chore(pkg): refactor: convert tests to testify assert/require part 16
2026-07-22 14:08:08 -06:00
Terry Howe
a6409a7eba
Merge pull request #32430 from mmorel-35/testifylint-manual-assert-pkg-15
...
chore(pkg): refactor: convert tests to testify assert/require part 15
2026-07-22 14:07:34 -06:00
Terry Howe
ea9e38035d
Merge pull request #32429 from mmorel-35/testifylint-manual-assert-pkg-14
...
chore(pkg): refactor: convert tests to testify assert/require part 14
2026-07-22 14:07:10 -06:00
Terry Howe
da9e2b6bab
Merge pull request #32428 from mmorel-35/testifylint-manual-assert-pkg-13
...
chore(pkg): refactor: convert tests to testify assert/require part 13
2026-07-22 14:06:31 -06:00
Terry Howe
f416c3b830
Merge pull request #32427 from mmorel-35/testifylint-manual-assert-pkg-12
...
chore(pkg): refactor: convert tests to testify assert/require part 12
2026-07-22 14:05:59 -06:00
Terry Howe
41627cd338
Merge pull request #32426 from mmorel-35/testifylint-manual-assert-pkg-11
...
chore(pkg): refactor: convert tests to testify assert/require part 11
2026-07-22 14:05:15 -06:00
Terry Howe
5d4165bfaf
Merge pull request #32425 from mmorel-35/testifylint-manual-assert-pkg-10
...
chore(pkg): refactor: convert tests to testify assert/require part 10
2026-07-22 14:04:36 -06:00
Terry Howe
00c2e025e5
Merge pull request #32424 from mmorel-35/testifylint-manual-assert-pkg-9
...
chore(pkg): refactor: convert tests to testify assert/require part 9
2026-07-22 14:04:09 -06:00
Terry Howe
78796e26bc
Merge pull request #32423 from mmorel-35/testifylint-manual-assert-pkg-8
...
chore(pkg): refactor: convert tests to testify assert/require part 8
2026-07-22 14:03:30 -06:00
Terry Howe
eea1defc88
Merge pull request #32422 from mmorel-35/testifylint-manual-assert-pkg-7
...
chore(pkg): refactor: convert tests to testify assert/require part 7
2026-07-22 14:02:56 -06:00
Matt Farina
598f567f83
Merge pull request #32400 from SetagGnaw/fix/upgrade-dependency-update-oci-panic
...
fix: pass registry client to downloader.Manager in upgrade
2026-07-22 15:35:10 -04:00
Robert Sirchia
69173e8ec1
Merge pull request #32451 from helm/dependabot/github_actions/main/github-actions-85dd5d8b53
...
chore(deps): bump the github-actions group with 4 updates
2026-07-22 15:21:50 -04:00
dependabot[bot]
ea7c838e08
chore(deps): bump the github-actions group with 4 updates
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.2 to 4.37.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e0647621c2...e4fba868fa )
Updates `github/codeql-action/autobuild` from 4.37.2 to 4.37.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e0647621c2...e4fba868fa )
Updates `github/codeql-action/analyze` from 4.37.2 to 4.37.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e0647621c2...e4fba868fa )
Updates `github/codeql-action/upload-sarif` from 4.37.2 to 4.37.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e0647621c2...e4fba868fa )
---
updated-dependencies:
- dependency-name: github/codeql-action/init
dependency-version: 4.37.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: github/codeql-action/autobuild
dependency-version: 4.37.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: github/codeql-action/analyze
dependency-version: 4.37.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: github/codeql-action/upload-sarif
dependency-version: 4.37.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-07-22 19:09:19 +00:00
Matt Farina
093825446e
Merge pull request #32439 from TerryHowe/chore/group-github-actions-dependabot
...
chore: group github-actions dependabot updates
2026-07-22 15:06:23 -04:00