Commit Graph
6398 Commits
Author SHA1 Message Date
Matt Farina 8ca401398d Merge pull request #10440 from jkmw/fix/10439
Fix memory leak in upgrade action
2021-12-07 11:48:12 -05:00
Jerome Küttner 9a492f8240 Channel should remain open if there is still a routine that wants to write into it
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
2021-12-06 18:07:47 +01:00
Jerome Küttner ad3d2cc8ef Fix memory leak in upgrade action
fixes helm/helm#10439

Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
2021-12-06 17:54:46 +01:00
Matt Farina 0e6e936ab8 Merge pull request #10410 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.2
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
2021-12-03 09:00:09 -05:00
Matthew Fisher 03d9e7ca62 Merge pull request #10425 from bridgetkromhout/CustomResourceDefinition-typo-fix
Bringing over an edit from the helm-www repo
2021-12-02 23:48:33 -08:00
Bridget Kromhout 21e1cd6027 Bringing over an edit from the helm-www repo
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
2021-12-02 15:48:57 -06:00
dependabot[bot] a840fb0940 chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
Bumps [github.com/Masterminds/squirrel](https://github.com/Masterminds/squirrel) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/Masterminds/squirrel/releases)
- [Commits](https://github.com/Masterminds/squirrel/compare/v1.5.1...v1.5.2)

---
updated-dependencies:
- dependency-name: github.com/Masterminds/squirrel
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-29 21:16:40 +00:00
Matthew Fisher 5d47255a3d Merge pull request #10230 from yxxhero/fix_sdk_namespace_issue
add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
2021-11-26 09:18:29 -08:00
Matthew Fisher 67f92d63fa Merge pull request #9640 from wangchenglong01/wangchl01
Add error check to avoid panic
2021-11-26 08:55:57 -08:00
Matthew Fisher c6961a9a78 Merge pull request #9794 from j6s/task/missing-dependency-message
Add hint to missing dependency message
2021-11-26 08:48:38 -08:00
Matthew Fisher a8d33e7df4 Merge pull request #9918 from cndoit18/fix-issue-9915
fix(install): fix 9915
2021-11-26 08:47:31 -08:00
Matthew Fisher de8034c097 Merge pull request #10390 from helm/dependabot/go_modules/github.com/mattn/go-shellwords-1.0.12
chore(deps): bump github.com/mattn/go-shellwords from 1.0.11 to 1.0.12
2021-11-26 08:34:10 -08:00
Matthew Fisher ad71cc1ab7 Merge pull request #10387 from bhavin192/sts-ready-fix
fix(pkg/kube): statefulSetReady: handle partition cases correctly
2021-11-26 08:33:46 -08:00
dependabot[bot] 664d5e63e3 chore(deps): bump github.com/mattn/go-shellwords from 1.0.11 to 1.0.12
Bumps [github.com/mattn/go-shellwords](https://github.com/mattn/go-shellwords) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/mattn/go-shellwords/releases)
- [Commits](https://github.com/mattn/go-shellwords/compare/v1.0.11...v1.0.12)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-shellwords
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-26 16:09:34 +00:00
Bhavin Gandhi c3310bb724 fix(pkg/kube): statefulSetReady: handle partition cases correctly
The partition value can be greater than number of replicas, in that
case no pods are rolled out. The expectedReplicas becomes a negative
number.
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#partitions

In the cases where the update does not change anything in the pod
template, the updatedReplicas value from StatefulSet status remains
unchanged. Such updates can still set some partition value, and
UpdatedReplicas is always greater than expectedReplicas. Basically,
the StatefulSet is ready / rolled-out.

In both the above scenarios, providing `--wait` flag causes it to
timeout waiting indefinitely. Because updatedReplicas can never be
negative, or be equal to the expectedReplicas for the second case.

This commit handles both the scenarios by checking if UpdatedReplicas
is smaller than expectedReplicas. If it is, then the StatefulSet is
not ready yet.

Based on the code from kubectl rollout:
https://github.com/kubernetes/kubectl/blob/a450ebd59c1e8917df23d37c6f05d8e16c3746aa/pkg/polymorphichelpers/rollout_status.go#L138-L141

Closes #8674

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
2021-11-26 19:06:25 +05:30
Martin Hickey e03d20d8f4 Merge pull request #10401 from indreias/indreias-patch-1
Add support for installing on Windows via Cygwin
2021-11-26 10:55:13 +00:00
Tyler AuerbeckandTyler Auerbeck 4bf99e54eb Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR (#10380)
* Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>

* Trigger Build

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>

Co-authored-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
2021-11-25 23:50:53 -08:00
Ioan Indreias 799339316f Add support for installing on Windows via Cygwin
Signed-off-by: Ioan Indreias <indreias@gmail.com>
2021-11-25 00:25:50 +02:00
Matt Farina 98c4ccf29b Merge pull request #10341 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.1
chore(deps): bump github.com/Masterminds/squirrel from 1.5.0 to 1.5.1
2021-11-23 09:26:08 -05:00
Matt Farina 0199f84014 Merge pull request #10342 from helm/dependabot/go_modules/github.com/gofrs/flock-0.8.1
chore(deps): bump github.com/gofrs/flock from 0.8.0 to 0.8.1
2021-11-23 09:25:52 -05:00
Matt Farina eb276db17f Merge pull request #10385 from mattfarina/k8s-1.22.4
Updating to Kubernetes 1.22.4 packages
2021-11-23 09:25:32 -05:00
Matt Farina c2da47e22b Updating to Kubernetes 1.22.4 packages
Signed-off-by: Matt Farina <matt.farina@suse.com>
2021-11-22 09:56:53 -05:00
Matt Farina 39471bcffd Merge pull request #9705 from helm/dependabot/go_modules/github.com/mitchellh/copystructure-1.2.0
chore(deps): Bump github.com/mitchellh/copystructure from 1.1.1 to 1.2.0
2021-11-22 09:34:27 -05:00
dependabot[bot] 6a1daecd0c chore(deps): bump github.com/Masterminds/squirrel from 1.5.0 to 1.5.1
Bumps [github.com/Masterminds/squirrel](https://github.com/Masterminds/squirrel) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/Masterminds/squirrel/releases)
- [Commits](https://github.com/Masterminds/squirrel/compare/v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: github.com/Masterminds/squirrel
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-19 21:41:13 +00:00
dependabot[bot] 6d96e5e4d6 chore(deps): Bump github.com/mitchellh/copystructure from 1.1.1 to 1.2.0
Bumps [github.com/mitchellh/copystructure](https://github.com/mitchellh/copystructure) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/mitchellh/copystructure/releases)
- [Commits](https://github.com/mitchellh/copystructure/compare/v1.1.1...v1.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-19 21:40:42 +00:00
Josh Dolitsky dd0177aed7 Merge pull request #10377 from bloodorangeio/oras-1.0.0
Upgrade to oras-go v1.0.0
2021-11-19 16:13:32 -05:00
Matt Farina 5f74c0e17f Merge pull request #10370 from mattfarina/fix-10367
Fix specifying of Kubernetes version from build scripts
2021-11-19 14:57:32 -05:00
Josh Dolitsky b66c468812 Upgrade to oras-go v1.0.0
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-11-19 11:24:41 -05:00
Matthew Fisher f7e56a27fc Merge pull request #10372 from zonggen/add-zonggen-to-triage-maintainers-list
OWNERS: add zonggen to triage maintainers list
2021-11-18 09:57:17 -08:00
Allen Bai 08eb75b3cd OWNERS: add zonggen to triage maintainers list
Ref: https://lists.cncf.io/g/cncf-helm/message/401
Signed-off-by: Allen Bai <abai@redhat.com>
2021-11-18 12:47:56 -05:00
Matt Farina 7838fb769d Fix specifying of Kubernetes version from build scripts
This bug came about because of three issues that this change
corrects:
- The CI scripts run on a pull request did not test building
  Helm. This means that a failure to set a variable using LDFLAGS
  had no opportunity to be caught.
- #8608 provided a means to match the k8s version used in linting
  and chartutil with the version of the package we pull in. With
  one problem. It attempts to set a const as if it were a string.
  This is ignored and everyone missed it.
- #10325 moved those constants to vars so it could be set. This
  looked good and passed tests but missed that you can't set an
  int as if it were a string. See first bullet.

This change fixes this by moved the internal representation to
be a string. These are internal variables not exposed in the public
API which makes this change non-breaking to the API.

Closes #10367

Signed-off-by: Matt Farina <matt.farina@suse.com>
2021-11-18 11:48:02 -05:00
dependabot[bot] 46a643fff4 chore(deps): bump github.com/gofrs/flock from 0.8.0 to 0.8.1
Bumps [github.com/gofrs/flock](https://github.com/gofrs/flock) from 0.8.0 to 0.8.1.
- [Release notes](https://github.com/gofrs/flock/releases)
- [Commits](https://github.com/gofrs/flock/compare/v0.8.0...v0.8.1)

---
updated-dependencies:
- dependency-name: github.com/gofrs/flock
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 16:40:44 +00:00
Matthew Fisher d31261f47c Merge pull request #10362 from helm/dependabot/go_modules/github.com/docker/docker-20.10.11incompatible
chore(deps): bump github.com/docker/docker from 20.10.9+incompatible to 20.10.11+incompatible
2021-11-18 08:27:32 -08:00
dependabot[bot] 7293ac2388 chore(deps): bump github.com/docker/docker
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.9+incompatible to 20.10.11+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/docker/docker/compare/v20.10.9...v20.10.11)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 09:37:59 +00:00
Martin Hickey f86694232b Merge pull request #10351 from helm/dependabot/go_modules/github.com/lib/pq-1.10.4
chore(deps): bump github.com/lib/pq from 1.10.3 to 1.10.4
2021-11-18 09:25:31 +00:00
dependabot[bot] fdb97665e4 chore(deps): bump github.com/lib/pq from 1.10.3 to 1.10.4
Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/lib/pq/releases)
- [Commits](https://github.com/lib/pq/compare/v1.10.3...v1.10.4)

---
updated-dependencies:
- dependency-name: github.com/lib/pq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-17 18:30:16 +00:00
Matt Farina 6809070032 Merge pull request #10325 from sboschman/lint-with-ldflags
allow ldflags to overwrite k8s version
2021-11-17 13:17:32 -05:00
Josh Dolitsky a63489ad28 Merge pull request #10294 from joshrwolf/oras-0.5
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
2021-11-16 13:33:25 -05:00
Josh Dolitsky 889c70b729 Add nolint comments
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-11-16 12:13:39 -05:00
Josh Dolitsky f77f93324d Merge remote-tracking branch 'upstream/main' into oras-0.5
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-11-16 12:05:33 -05:00
Martin Hickey f9a8fc8199 Merge pull request #10347 from hickeyma/fix/signal-notify-use
fix(install/upgrade): Use buffered channel for signal notification to avoid signal loss
2021-11-16 17:00:04 +00:00
Josh Dolitsky 3841af9a96 update CI to use Go 1.17
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
2021-11-16 11:43:01 -05:00
Josh Dolitsky b27b5551e0 Merge branch 'main' into oras-0.5 2021-11-16 10:45:27 -05:00
Martin Hickey ea1b1f5a07 Use buffered channel for signal notification
Refer to https://pkg.go.dev/os/signal#Notify for more details.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2021-11-16 15:42:48 +00:00
Matthew Fisher 3c7a370145 Merge pull request #10313 from brandoncole/main
Fixes a SIGSEGV similar to issue 1347
2021-11-15 14:10:26 -08:00
Matthew Fisher d16ce2d9c9 Merge pull request #10131 from helm/dependabot/go_modules/github.com/BurntSushi/toml-0.4.1
Bump github.com/BurntSushi/toml from 0.3.1 to 0.4.1
2021-11-15 10:31:36 -08:00
Matthew Fisher 473cd68eb5 Merge pull request #10268 from helm/dependabot/go_modules/k8s.io/klog/v2-2.30.0
chore(deps): bump k8s.io/klog/v2 from 2.9.0 to 2.30.0
2021-11-15 10:30:16 -08:00
Matthew Fisher 27b7cfcddb Merge pull request #10334 from werf/fix-resource-validation-error
fix: added resource info into the validation error
2021-11-15 10:27:51 -08:00
Matthew Fisher 2f43e1d1f7 Merge pull request #10337 from helm/dependabot/go_modules/sigs.k8s.io/yaml-1.3.0
chore(deps): bump sigs.k8s.io/yaml from 1.2.0 to 1.3.0
2021-11-15 10:27:08 -08:00
Matthew Fisher 4cb4f089d9 Merge pull request #10302 from centic9/fail_script_get_if_target_dir_is_missing
Fail if target-directory does not exist
2021-11-15 07:28:15 -08:00