Merge pull request #9048 from MaXinjian/install

Cleanup tempfiles introduced by unit tests under pkg/

pkg/downloader/chart_downloader_test.go

@@ -283,6 +283,7 @@ func TestDownloadTo_VerifyLater(t *testing.T) {
 	defer ensure.HelmHome(t)()
 
 	dest := ensure.TempDir(t)
+	defer os.RemoveAll(dest)
 
 	// Set up a fake repo
 	srv, err := repotest.NewTempServerWithCleanup(t, "testdata/*.tgz*")

pkg/plugin/installer/local_installer_test.go

@@ -50,4 +50,5 @@ func TestLocalInstaller(t *testing.T) {
 	if i.Path() != helmpath.DataPath("plugins", "echo") {
 		t.Fatalf("expected path '$XDG_CONFIG_HOME/helm/plugins/helm-env', got %q", i.Path())
 	}
+	defer os.RemoveAll(filepath.Dir(helmpath.DataPath())) // helmpath.DataPath is like /tmp/helm013130971/helm
 }

pkg/repo/chartrepo_test.go

@@ -148,6 +148,7 @@ func TestIndexCustomSchemeDownload(t *testing.T) {
 		t.Fatalf("Problem loading chart repository from %s: %v", repoURL, err)
 	}
 	repo.CachePath = ensure.TempDir(t)
+	defer os.RemoveAll(repo.CachePath)
 
 	tempIndexFile, err := ioutil.TempFile("", "test-repo")
 	if err != nil {

pkg/repo/repotest/server_test.go

@@ -18,6 +18,7 @@ package repotest
 import (
 	"io/ioutil"
 	"net/http"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -33,6 +34,7 @@ func TestServer(t *testing.T) {
 	defer ensure.HelmHome(t)()
 
 	rootDir := ensure.TempDir(t)
+	defer os.RemoveAll(rootDir)
 
 	srv := NewServer(rootDir)
 	defer srv.Stop()