dilim/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-08-04 15:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(pkg/storage): If storage.Create fails to clean up recent release versions, return an error

Browse Source 
Previously, storage.Create was ignoring the error. This meant that a user that
relied on the recent release version cleanup would not be notified if that
cleanup failed, and release versions could grow without bound.

Closes #9145

Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
This commit is contained in:
Daniel Lipovetsky
2020-12-15 10:00:07 -08:00
parent 8c28da6567
commit 00cf10d360
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/storage/storage.go
View File

@@ -61,7 +61,10 @@ func (s *Storage) Create(rls *rspb.Release) error {
s.Log("creating release %q", makeKey(rls.Name, rls.Version))
if s.MaxHistory > 0 {
// Want to make space for one more release.
s.removeLeastRecent(rls.Name, s.MaxHistory-1)
if err := s.removeLeastRecent(rls.Name, s.MaxHistory-1); err != nil &&
!errors.Is(err, driver.ErrReleaseNotFound) {
return err
}
}
return s.Driver.Create(makeKey(rls.Name, rls.Version), rls)
}