Junio C Hamano a650ad996d odb: do not use "blank" substitute for NULL
When various *object_info() functions are given an extended object
info structure as NULL by a caller that does not want any details,
the code uses a file-scope static blank_oi and passes it down to
the helper functions they use, to avoid handling NULL specifically.

The ps/object-read-stream topic graduated to 'master' recently
however had a bug that assumed that two identically named file-scope
static variables in two functions are the same, which of course is
not the case.  This made "git commit" take 0.38 seconds to 1508
seconds in some case, as reported by Aaron Plattner here:

  https://lore.kernel.org/git/f4ba7e89-4717-4b36-921f-56537131fd69@nvidia.com/

We _could_ move the blank_oi variable to the global scope in common
section to fix this regression, but explicitly handling the NULL is
a much safer fix.  It would also reduce the chance of errors that
somebody accidentally writes into blank_oi, making its contents
dirty, which potentially will make subsequent calls into the
function misbehave.  By explicitly handling NULL input, we no longer
have to worry about it.

Reported-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-12-18 20:48:01 +09:00
2025-11-12 08:17:31 -08:00
2025-11-17 07:35:33 -08:00
2025-10-15 08:10:17 -07:00
2025-08-02 22:44:58 -07:00
2025-10-14 12:56:09 -07:00
2025-10-08 12:17:55 -07:00
2025-10-26 16:34:39 -07:00
2025-09-08 14:54:35 -07:00
2025-07-15 15:18:18 -07:00
2025-09-16 11:37:06 -07:00
2025-09-16 18:00:25 -07:00
2025-09-16 18:00:25 -07:00
2025-08-21 13:46:58 -07:00
2025-08-04 08:10:33 -07:00
2025-08-21 13:46:59 -07:00
2025-07-23 08:15:18 -07:00
2025-11-03 06:49:55 -08:00
2025-09-12 08:59:52 -07:00
2025-10-22 11:38:58 -07:00
2025-11-17 07:35:33 -08:00
2025-10-07 12:25:27 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-08-21 13:46:59 -07:00
2025-07-15 15:18:18 -07:00
2025-08-21 13:46:59 -07:00
2025-10-08 12:17:55 -07:00
2025-11-04 07:48:07 -08:00
2025-08-21 13:46:58 -07:00
2025-08-21 13:46:58 -07:00
2025-10-26 19:48:21 -07:00
2025-11-03 12:18:45 -08:00
2025-07-15 15:18:18 -07:00
2025-08-21 13:46:59 -07:00
2025-07-23 08:15:18 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 616 MiB
Languages
C 49.9%
Shell 39.5%
Perl 4.3%
Tcl 3%
Python 0.8%
Other 2.2%