http: avoid closing index-pack input twice

finish_http_pack_request() passes its staging-file descriptor to
index-pack through child_process.in. start_command() takes ownership
of a supplied descriptor and closes it, even when starting the child
fails.

Do not close the descriptor again after run_command() returns.

Signed-off-by: Ted Nyman <tnyman@openai.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ted Nyman
2026-07-26 17:28:39 -07:00
committed by Junio C Hamano
parent c71ed75a8b
commit f0d866a2ea

7
http.c
View File

@@ -2704,13 +2704,8 @@ int finish_http_pack_request(struct http_pack_request *preq)
else
ip.no_stdout = 1;
if (run_command(&ip)) {
if (run_command(&ip))
ret = -1;
goto cleanup;
}
cleanup:
close(tmpfile_fd);
unlink(preq->tmpfile.buf);
return ret;
}