Tonis Tiigi b749b54c58 remotes/docker: close request body when authorization fails ...

The pusher creates the upload request body as an io.Pipe. request.do
attaches the pipe reader to the request before calling Authorize. If
Authorize fails, do returns before client.Do, so the reader is never
handed to the HTTP client, which would have closed it, and nothing else
closes it.

A concurrent pushWriter.Write then blocks forever in pipe.Write. It only
reads the error reported by the request goroutine after the pipe is
closed, and it takes no context, so cancelling the caller does not help.
Callers such as content.Copy never return, and anything they hold, for
example a concurrency slot, is never released.

Close the body when authorization fails so the blocked Write returns the
authorization error. Transient errors keep going through the existing
retry and content.ErrReset handling.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

2026-10-21 23:18:59 +00:00

..

auth

core: modernize: rangeint

2026-03-15 14:56:35 +01:00

config

core/remotes/docker: use SystemCertPool on Windows

2026-03-26 13:00:13 +01:00

authorizer.go

all: Use errors.AsType

2026-09-02 18:51:15 +02:00

converter_fuzz_test.go

Move fuzz tests to go native fuzz [part1]

2024-12-24 22:48:20 +00:00

converter.go

Move remotes to core/remotes

2024-01-17 09:52:21 -08:00

errcode.go

replace some uses of interface{} in (go)docs

2026-03-17 13:38:25 +01:00

errdesc.go

Move remotes to core/remotes

2024-01-17 09:52:21 -08:00

fetcher_fuzz_test.go

Add referrers fetcher to remotes

2025-09-24 17:59:18 -07:00

fetcher_test.go

Merge commit from fork

2026-10-13 11:46:14 -07:00

fetcher.go

Merge commit from fork

2026-10-13 11:46:14 -07:00

handler_test.go

Move reference to pkg/reference

2024-01-17 09:55:58 -08:00

handler.go

*: modernize: stringsseq

2026-03-15 18:24:13 +01:00

httpreadseeker.go

content, remotes: bound reads to expected size

2026-10-09 11:54:42 -07:00

pusher_test.go

remotes/docker: close request body when authorization fails

2026-10-21 23:18:59 +00:00

pusher.go

remotes/docker: Propagate registry warnings to resolver

2026-07-13 12:15:30 +02:00

referrers_test.go

Add size check to referrers response

2025-11-03 12:10:54 -08:00

referrers.go

Add size check to referrers response

2025-11-03 12:10:54 -08:00

registry_test.go

Move remotes to core/remotes

2024-01-17 09:52:21 -08:00

registry.go

Add: ResponseHeaderTimeout to image pull HTTP transport

2026-04-05 02:58:02 +05:30

resolver_test.go

remotes: surface OCI error body on HEAD 403 via GET fallback

2026-07-07 21:19:39 +00:00

resolver_unix.go

Use unix and windows specific connection error checks

2024-06-05 14:39:57 -07:00

resolver_windows.go

Use unix and windows specific connection error checks

2024-06-05 14:39:57 -07:00

resolver.go

remotes/docker: close request body when authorization fails

2026-10-21 23:18:59 +00:00

scope_test.go

Move reference to pkg/reference

2024-01-17 09:55:58 -08:00

scope.go

chore: fix broken links to https://docs.docker.com/registry

2025-04-17 11:20:23 +01:00

status.go

Switch to new errdefs package

2024-01-25 22:18:45 -08:00

warnings_test.go

remotes/docker: Propagate registry warnings to resolver

2026-07-13 12:15:30 +02:00

warnings.go

remotes/docker: Propagate registry warnings to resolver

2026-07-13 12:15:30 +02:00