Tonis Tiigi b749b54c58 remotes/docker: close request body when authorization fails ...

The pusher creates the upload request body as an io.Pipe. request.do
attaches the pipe reader to the request before calling Authorize. If
Authorize fails, do returns before client.Do, so the reader is never
handed to the HTTP client, which would have closed it, and nothing else
closes it.

A concurrent pushWriter.Write then blocks forever in pipe.Write. It only
reads the error reported by the request goroutine after the pipe is
closed, and it takes no context, so cancelling the caller does not help.
Callers such as content.Copy never return, and anything they hold, for
example a concurrency slot, is never released.

Close the body when authorization fails so the blocked Write returns the
authorization error. Transient errors keep going through the existing
retry and content.ErrReset handling.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

2026-10-21 23:18:59 +00:00

..

docker

remotes/docker: close request body when authorization fails

2026-10-21 23:18:59 +00:00

errors

Register remote errors for clients to access registry errors

2025-06-11 18:00:24 -07:00

handlers_test.go

remotes: PushHandler: reject negative descriptor sizes

2026-10-20 09:39:54 +00:00

handlers.go

remotes: PushHandler: reject negative descriptor sizes

2026-10-20 09:39:54 +00:00

resolver.go

Update referrers interface to support more options

2025-10-28 22:37:05 -07:00