Commit Graph

15669 Commits

Author SHA1 Message Date
Derek McGowan
843aee8d3f Merge pull request #12342 from dmcgowan/fix-sandbox-client
Fixes for sandbox client
2025-10-03 20:39:45 +00:00
Fu Wei
61ddcd5372 Merge pull request #12063 from dmcgowan/mount-manager
Add mount manager
2025-10-03 14:01:38 +00:00
Fu Wei
3f0fddb726 Merge pull request #12338 from henry118/fix-test
Fix integ-test: looking for sleep inf as longCommand
2025-10-02 23:27:24 +00:00
Derek McGowan
637429a252 Update logging for sandbox controller service
Add more details and differentiate log line from sandbox store calls

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-10-01 17:14:16 -07:00
Maksym Pavlenko
2d28d98490 Merge pull request #12339 from containerd/dependabot/github_actions/github/codeql-action-3.30.5
build(deps): bump github/codeql-action from 3.30.3 to 3.30.5
2025-10-01 23:25:22 +00:00
Derek McGowan
0057735f99 Merge pull request #12337 from osamakader/display-platforms-format
pkg/display: use platforms.Format for platform display
2025-10-01 23:06:42 +00:00
Derek McGowan
f0aeb9037e Add sandbox controller create call to client
Currently the new sandbox returns a sandbox client which will error when
start is called. The new sandbox should also create the sandbox with the
sandbox controller.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-10-01 16:04:37 -07:00
Derek McGowan
a338d8b2fb Fix sandbox client shutdown to ignore not found errors
The logic is reversed, not found errors should be ignored

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-10-01 16:04:36 -07:00
Derek McGowan
54ba402a29 Add default sandboxer to client
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-10-01 16:04:36 -07:00
Akihiro Suda
ac811452f0 Merge pull request #12340 from containerd/dependabot/github_actions/actions/cache-4.3.0
build(deps): bump actions/cache from 4.2.4 to 4.3.0
2025-10-01 06:16:29 +00:00
Akihiro Suda
c4fa5dbc85 Merge pull request #12341 from containerd/dependabot/github_actions/docker/login-action-3.6.0
build(deps): bump docker/login-action from 3.5.0 to 3.6.0
2025-10-01 06:16:12 +00:00
Derek McGowan
c7b3114ebb Update mount manager code documentation
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-30 13:37:11 -07:00
Derek McGowan
f3af360f6d Update runtime to read allowed custom mounts from runtime
Let the runtime specify which custom mounts it will support

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-30 13:37:11 -07:00
dependabot[bot]
2189d3d6ce build(deps): bump docker/login-action from 3.5.0 to 3.6.0
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](184bdaa072...5e57cd1181)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 3.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-30 03:07:57 +00:00
dependabot[bot]
cfb1b653db build(deps): bump actions/cache from 4.2.4 to 4.3.0
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 4.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](0400d5f644...0057852bfa)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-30 01:21:37 +00:00
Derek McGowan
94e6bcea50 Add support for allowing custom types through mount manager
Allow the mount manager to skip handling of custom types. Ensure that
custom types are still working with formatted mounts.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:38 -07:00
Derek McGowan
efc9950114 Add runtimes option to task manager
Allow task manager to fetch info on runtimes at startup.
Use this info to configure whether the runtime allows formatted mounts.
This info could also be used in the future to enforce policy such as
requiring a pre-known set of runtimes or specific runtime properties.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:38 -07:00
Derek McGowan
dd9c43150a Add option to allow formatted mounts
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:38 -07:00
Derek McGowan
9c21e867ed Handle flaky case for loop autoclear
The autoclear may take a bit of time to clear out the file, check
multiple times for the file to get removed before returning an error.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:37 -07:00
Derek McGowan
f7b77e649c Update mount manager cleanup logic
Avoid keeping file descriptor open to directory which is getting
removed. Update error handling and wrapping to provide more clarity
around failures.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:37 -07:00
Derek McGowan
069cbfe8f0 Use mount manager for temp mounts
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:37 -07:00
Derek McGowan
93070961b7 Update snapshotter tests to use mount manager
Create separate package for snapshotter test in metadata package to
prevent circular dependency.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:36 -07:00
Derek McGowan
fa327566bb Fix mount manager deactivate errors
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:36 -07:00
Derek McGowan
9c0cc4a424 Add mount manager format test
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:36 -07:00
Derek McGowan
61b8426ae1 Add mount manager documentation
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:36 -07:00
Derek McGowan
67f0970a54 Add mount activation integration test
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:35 -07:00
Derek McGowan
39f128b994 fix invalid deactivate error
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:35 -07:00
Derek McGowan
76a877bb5c Add mount activation support to task service
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:35 -07:00
Derek McGowan
5b4de2c34f Add implementation of list and get mount activation
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:34 -07:00
Derek McGowan
184fae60fc Add backreference support to mount manager
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:34 -07:00
Derek McGowan
9794addcea Add mount formatting test
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:34 -07:00
Derek McGowan
d8e5cdd76a Fix gc cleanup and add unit tests for gc
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:34 -07:00
Derek McGowan
49634889f8 Update ctr image mounts to use mount manager
Updates the image mounts to use temporary mounts and no longer require
passing in a target directory.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:33 -07:00
Derek McGowan
62062902f5 Add support for mount manager to ctr snapshots mount
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:33 -07:00
Derek McGowan
563b28154c Add mount manager to client
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:33 -07:00
Derek McGowan
c8e7674cc9 Add temporary mount support to manager
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:33 -07:00
Derek McGowan
aba772012a Add debug logs to mount service calls
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:32 -07:00
Derek McGowan
d23e635a5c Fix mount manager plugin when no handlers provided
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:32 -07:00
Derek McGowan
75ed5e0037 Fix mount manager gc
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:32 -07:00
Derek McGowan
8db3010865 Add mounts api service
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:31 -07:00
Derek McGowan
67fbf9db9c Generate and vendor proto changes
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:31 -07:00
Derek McGowan
c5097ac63f Add mount manager to protobuf services and types
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:31 -07:00
Derek McGowan
4d34b01ce0 Add loopback and overlay mount manager tests
Signed-off-by: Derek McGowan <derek@mcg.dev>
2025-09-29 17:08:31 -07:00
dependabot[bot]
0e88cde87e build(deps): bump github/codeql-action from 3.30.3 to 3.30.5
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.3 to 3.30.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](192325c861...3599b3baa1)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-29 23:51:54 +00:00
Henry Wang
5a00693e7f Fix integ-test: looking for sleep inf as longCommand
Signed-off-by: Henry Wang <henwang@amazon.com>
2025-09-29 19:44:33 +00:00
Osama Abdelkader
739821fc5d pkg/display: use platforms.Format for platform display
Replace manual platform formatting with containerd's platforms.Format()
function to ensure consistent platform string formatting across the
codebase. This removes the TODO comment and handles platform variants
properly.

Fixes the TODO in manifest_printer.go line 124.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
2025-09-29 18:15:34 +03:00
Fu Wei
1b613badfa Merge pull request #12309 from dmcgowan/remote-referrers
Add referrers fetcher to remotes
2025-09-26 19:06:24 +00:00
Fu Wei
1e84794c57 Merge pull request #12331 from henry118/fix-progress
Prevent goroutine hangs during ProgressTracker shutdown
2025-09-26 18:57:54 +00:00
Henry Wang
748cd9f037 Prevent goroutine hangs during ProgressTracker shutdown
Signed-off-by: Henry Wang <henwang@amazon.com>
2025-09-25 18:50:14 +00:00
Phil Estes
8750a368fb Merge pull request #12325 from ArangoGutierrez/mxpv.conf.typos
Fix typos introduced on PR 12323
2025-09-25 18:21:01 +00:00