hack: add linting for multiple combinations of build tags

We can't just add new build-tags, since this tests only the combination
of all of the provided tags.  For the instance of nydus, we need to test
with *and* without the build tag.

Signed-off-by: Justin Chadwell <me@jedevc.com>
This commit is contained in:
Justin Chadwell
2023-07-27 09:39:34 +01:00
parent 01e6ba62fd
commit f663123fc3
3 changed files with 29 additions and 8 deletions

View File

@@ -5,9 +5,6 @@ run:
modules-download-mode: vendor
build-tags:
- dfrunsecurity
linters:
enable:
- depguard

View File

@@ -79,9 +79,22 @@ group "validate" {
}
target "lint" {
name = "lint-${buildtags.name}"
inherits = ["_common"]
dockerfile = "./hack/dockerfiles/lint.Dockerfile"
output = ["type=cacheonly"]
target = buildtags.target
args = {
BUILDTAGS = buildtags.tags
}
matrix = {
buildtags = [
{ name = "default", tags = "", target = "golangci-lint" },
{ name = "labs", tags = "dfrunsecurity", target = "golangci-lint" },
{ name = "nydus", tags = "nydus", target = "golangci-lint" },
{ name = "yaml", tags = "", target = "yamllint" },
]
}
}
target "validate-vendor" {

View File

@@ -2,13 +2,24 @@
ARG GO_VERSION=1.20
FROM golang:${GO_VERSION}-alpine
FROM golang:${GO_VERSION}-alpine AS base
ENV GOFLAGS="-buildvcs=false"
RUN apk add --no-cache gcc musl-dev yamllint
RUN wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.52.2
WORKDIR /go/src/github.com/moby/buildkit
FROM base as golangci-lint
ARG BUILDTAGS
RUN --mount=target=/go/src/github.com/moby/buildkit --mount=target=/root/.cache,type=cache,sharing=locked \
GOARCH=amd64 golangci-lint run --build-tags "${BUILDTAGS}" && \
GOARCH=arm64 golangci-lint run --build-tags "${BUILDTAGS}" && \
touch /golangci-lint.done
FROM base as yamllint
RUN --mount=target=/go/src/github.com/moby/buildkit --mount=target=/root/.cache,type=cache \
GOARCH=amd64 golangci-lint run && \
GOARCH=arm64 golangci-lint run
RUN --mount=target=/go/src/github.com/moby/buildkit --mount=target=/root/.cache,type=cache \
yamllint -c .yamllint.yml --strict .
yamllint -c .yamllint.yml --strict . && \
touch /yamllint.done
FROM scratch
COPY --link --from=golangci-lint /golangci-lint.done /
COPY --link --from=yamllint /yamllint.done /