dilim/FFmpeg
1
0 Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2026-11-06 05:17:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

libavformat/flacdec: error on overflow in metadata

Browse Source 
if accumulating metadata_head_size would lead to an integer overflow,
return an error instead
This commit is contained in:
Ted Meyer authored and Lynne committed 2026-10-24 02:31:48 +00:00
1 parent 598857bf35
commit d8990137ee
1 file changed
+8 -3
Download Patch File Download Diff File Expand all files Collapse all files
libavformat/flacdec.c
+8 -3
View File
@@ -42,12 +42,16 @@ typedef struct FLACDecContext {
AVCodecContext *parser_dec;
} FLACDecContext;
static void reset_index_position(int64_t metadata_head_size, AVStream *st)
static int reset_index_position(int64_t metadata_head_size, AVStream *st)
{
FFStream *const sti = ffstream(st);
/* the real seek index offset should be the size of metadata blocks with the offset in the frame blocks */
for (int i = 0; i < sti->nb_index_entries; i++)
for (int i = 0; i < sti->nb_index_entries; i++) {
if (0x7FFFFFFFFFFFFFFF - metadata_head_size < sti->index_entries[i].pos)
return AVERROR_INVALIDDATA;
sti->index_entries[i].pos += metadata_head_size;
}
return 0;
}
static const uint16_t sr_table[16] = {
@@ -225,7 +229,8 @@ static int flac_read_header(AVFormatContext *s)
if (ret < 0)
return ret;
reset_index_position(avio_tell(s->pb), st);
if (ret = reset_index_position(avio_tell(s->pb), st))
return ret;
return 0;
fail: