dilim/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-08-02 22:09:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmMakefile: Remove superfluous overload

Browse Source 
Explicit is better than implicit.
This commit is contained in:
Stephen Kelly
2016-10-07 20:13:34 +02:00
parent 3e8d47d18b
commit c8ec8d6a7e
3 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmLinkLibrariesCommand.cxx
View File

@@ -30,7 +30,7 @@ bool cmLinkLibrariesCommand::InitialPass(std::vector<std::string> const& args,
}
this->Makefile->AddLinkLibrary(*i, OPTIMIZED_LibraryType);
} else {
this->Makefile->AddLinkLibrary(*i);
this->Makefile->AddLinkLibrary(*i, GENERAL_LibraryType);
}
}

5
Source/cmMakefile.cxx
View File

@@ -1267,11 +1267,6 @@ void cmMakefile::AddLinkDirectoryForTarget(const std::string& target,
}
}
void cmMakefile::AddLinkLibrary(const std::string& lib)
{
this->AddLinkLibrary(lib, GENERAL_LibraryType);
}
void cmMakefile::InitializeFromParent(cmMakefile* parent)
{
this->SystemIncludeDirectories = parent->SystemIncludeDirectories;

1
Source/cmMakefile.h
View File

@@ -199,7 +199,6 @@ public:
/**
* Add a link library to the build.
*/
void AddLinkLibrary(const std::string&);
void AddLinkLibrary(const std::string&, cmTargetLinkLibraryType type);
void AddLinkLibraryForTarget(const std::string& tgt, const std::string&,
cmTargetLinkLibraryType type);