Daan De Meyer
4b95bda8c1
clang-tidy: flag direct open(), openat() and creat() calls
...
The tree opens files via the xopenat() family, which sets O_CLOEXEC on
its own and refuses to create files through dangling symlinks. Nothing
stops new code from calling open() directly though. The repart manifest
code added such a call after the migration. Let's add open(), openat()
and creat() to the custom functions of bugprone-unsafe-functions so that
clang-tidy reports direct calls.
The functions that implement xopenat() and fd_reopen() call the syscalls
directly, and so do the seccomp tests and the O_EMPTYPATH probe in
test-fd-util.c. We suppress the check in those places.
openat2() isn't on the list. override/fcntl.h defines openat2 as a macro
for openat2_shim(), and the check ignores calls that come from a macro
expansion. An entry for openat2() wouldn't report anything.
2026-11-03 16:30:36 +01:00
..
2026-01-31 01:11:11 +09:00
2026-04-14 17:32:37 +01:00
2022-05-21 18:09:50 +02:00
2026-02-12 17:49:19 +00:00
2024-11-29 14:18:15 +01:00
2024-04-17 20:53:49 +02:00
2021-10-18 09:43:18 +02:00
2021-06-24 10:20:29 +02:00
2026-01-31 01:11:11 +09:00
2024-07-12 14:38:09 +01:00
2026-10-25 17:27:54 +01:00
2026-01-31 01:11:11 +09:00
2025-11-12 23:01:35 +00:00
2026-01-31 01:11:11 +09:00
2026-11-02 11:07:30 +01:00
2024-02-23 09:48:47 +01:00
2026-02-18 03:28:12 +09:00
2026-01-31 01:11:11 +09:00
2026-09-17 11:49:45 +09:00
2025-04-25 00:42:24 +01:00
2024-03-27 07:11:55 +01:00
2026-03-24 17:55:26 +01:00
2026-11-03 16:30:36 +01:00
2026-04-13 16:41:33 +01:00
2026-10-27 16:58:05 -04:00
2026-10-05 09:35:58 +02:00
2026-01-31 01:11:11 +09:00
2024-12-19 15:35:55 +01:00
2026-01-31 01:11:11 +09:00
2026-10-20 06:55:47 +02:00
2024-06-03 15:22:54 +09:00
2026-01-31 01:11:11 +09:00
2026-01-31 01:11:11 +09:00
2022-11-02 07:31:18 +09:00
2025-07-07 17:28:47 +00:00
2026-01-31 01:11:11 +09:00
2025-11-19 20:00:25 +01:00
2024-12-19 15:35:55 +01:00
2026-11-02 13:29:09 +01:00
2026-10-29 19:53:35 +01:00
2026-01-31 01:11:11 +09:00
2026-02-12 17:49:19 +00:00
2026-10-31 10:20:30 +00:00
2026-10-02 14:58:43 +02:00
2025-05-14 18:06:04 +02:00
2026-10-30 13:20:54 +01:00
2026-09-17 11:49:45 +09:00
2026-02-09 02:36:50 +01:00
2026-01-16 22:56:08 +09:00
2026-06-06 13:44:49 +01:00
2024-04-17 21:21:23 +02:00
2026-10-27 16:00:46 +09:00
2026-03-12 09:37:24 +01:00
2026-01-31 01:11:11 +09:00
2026-10-02 14:56:31 +02:00
2026-04-09 22:47:10 +02:00
2025-10-24 01:52:59 +09:00
2025-11-25 22:52:10 +09:00
2026-01-31 01:11:11 +09:00
2026-01-31 01:11:11 +09:00
2026-10-05 09:35:58 +02:00
2025-12-18 10:50:23 +01:00
2025-11-19 20:00:25 +01:00
2025-12-31 10:59:41 -05:00
2026-01-29 00:40:18 +09:00
2026-10-19 11:28:33 +02:00
2026-09-17 11:49:45 +09:00
2025-11-23 17:16:09 +01:00
2026-01-31 01:11:11 +09:00
2026-01-31 01:11:11 +09:00
2026-07-02 15:05:14 +01:00
2026-09-17 11:49:45 +09:00
2026-10-30 13:20:54 +01:00
2026-09-17 11:49:45 +09:00
2025-07-22 18:03:39 +01:00
2026-09-17 11:49:45 +09:00
2026-02-12 17:49:19 +00:00
2026-06-01 15:06:20 +01:00
2024-04-17 21:21:23 +02:00
2026-03-12 09:38:03 +01:00
2026-01-31 01:11:11 +09:00
2026-09-17 11:49:45 +09:00
2026-01-30 13:19:33 +09:00
2026-01-31 01:11:11 +09:00
2025-04-16 08:30:25 +09:00
2026-01-31 01:11:11 +09:00
2024-04-17 21:21:23 +02:00
2026-10-16 09:16:07 +02:00
2026-10-29 13:02:45 +01:00
2026-05-14 08:55:44 +02:00
2024-02-23 09:48:47 +01:00
2026-02-24 18:29:37 +01:00
2026-07-12 23:09:01 +02:00
2026-01-31 01:11:11 +09:00
2024-04-17 21:21:23 +02:00
2026-08-16 10:25:33 +01:00
2026-01-31 01:11:11 +09:00
2026-10-19 11:28:33 +02:00
2024-03-15 04:04:01 +09:00
2026-01-31 01:11:11 +09:00
2026-09-22 18:46:41 +02:00
2024-03-27 07:31:54 +01:00
2026-09-17 11:49:45 +09:00
2026-04-02 12:55:33 +02:00