mirror of
https://github.com/systemd/systemd.git
synced 2026-07-12 02:24:15 +00:00
de61a04b18
This fixes repart's, systemctl's, sysusers' and tmpfiles' specifier expansion to honour the root dir specified with --root=. This is relevant for specifiers such as %m, %o, … which are directly sourced from files on disk. This doesn't try to be overly smart: specifiers referring to runtime concepts (i.e. boot ID, architecture, hostname) rather than files on the medium are left as is. There's certainly a point to be made that they should fail in case --root= is specified, but I am not entirely convinced about that, and it's certainly something we can look into later if there's reason to. I wondered for a while how to hook this up best, but given that quite a large number of specifiers resolve to data from files on disks, and most of our tools needs this, I ultimately decided to make the root dir a first class parameter to specifier_printf(). Replaces: #16187 Fixes: #16183
128 lines
3.6 KiB
C
128 lines
3.6 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
|
|
#include "format-util.h"
|
|
#include "install-printf.h"
|
|
#include "install.h"
|
|
#include "macro.h"
|
|
#include "specifier.h"
|
|
#include "string-util.h"
|
|
#include "unit-name.h"
|
|
#include "user-util.h"
|
|
|
|
static int specifier_prefix_and_instance(char specifier, const void *data, const char *root, const void *userdata, char **ret) {
|
|
const UnitFileInstallInfo *i = userdata;
|
|
_cleanup_free_ char *prefix = NULL;
|
|
int r;
|
|
|
|
assert(i);
|
|
|
|
r = unit_name_to_prefix_and_instance(i->name, &prefix);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
if (endswith(prefix, "@") && i->default_instance) {
|
|
char *ans;
|
|
|
|
ans = strjoin(prefix, i->default_instance);
|
|
if (!ans)
|
|
return -ENOMEM;
|
|
*ret = ans;
|
|
} else
|
|
*ret = TAKE_PTR(prefix);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int specifier_name(char specifier, const void *data, const char *root, const void *userdata, char **ret) {
|
|
const UnitFileInstallInfo *i = userdata;
|
|
char *ans;
|
|
|
|
assert(i);
|
|
|
|
if (unit_name_is_valid(i->name, UNIT_NAME_TEMPLATE) && i->default_instance)
|
|
return unit_name_replace_instance(i->name, i->default_instance, ret);
|
|
|
|
ans = strdup(i->name);
|
|
if (!ans)
|
|
return -ENOMEM;
|
|
*ret = ans;
|
|
return 0;
|
|
}
|
|
|
|
static int specifier_prefix(char specifier, const void *data, const char *root, const void *userdata, char **ret) {
|
|
const UnitFileInstallInfo *i = userdata;
|
|
|
|
assert(i);
|
|
|
|
return unit_name_to_prefix(i->name, ret);
|
|
}
|
|
|
|
static int specifier_instance(char specifier, const void *data, const char *root, const void *userdata, char **ret) {
|
|
const UnitFileInstallInfo *i = userdata;
|
|
char *instance;
|
|
int r;
|
|
|
|
assert(i);
|
|
|
|
r = unit_name_to_instance(i->name, &instance);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
if (isempty(instance)) {
|
|
r = free_and_strdup(&instance, strempty(i->default_instance));
|
|
if (r < 0)
|
|
return r;
|
|
}
|
|
|
|
*ret = instance;
|
|
return 0;
|
|
}
|
|
|
|
static int specifier_last_component(char specifier, const void *data, const char *root, const void *userdata, char **ret) {
|
|
_cleanup_free_ char *prefix = NULL;
|
|
char *dash;
|
|
int r;
|
|
|
|
r = specifier_prefix(specifier, data, root, userdata, &prefix);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
dash = strrchr(prefix, '-');
|
|
if (dash) {
|
|
dash = strdup(dash + 1);
|
|
if (!dash)
|
|
return -ENOMEM;
|
|
*ret = dash;
|
|
} else
|
|
*ret = TAKE_PTR(prefix);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int install_full_printf_internal(const UnitFileInstallInfo *i, const char *format, size_t max_length, const char *root, char **ret) {
|
|
/* This is similar to unit_name_printf() */
|
|
|
|
const Specifier table[] = {
|
|
{ 'i', specifier_instance, NULL },
|
|
{ 'j', specifier_last_component, NULL },
|
|
{ 'n', specifier_name, NULL },
|
|
{ 'N', specifier_prefix_and_instance, NULL },
|
|
{ 'p', specifier_prefix, NULL },
|
|
|
|
COMMON_SYSTEM_SPECIFIERS,
|
|
|
|
COMMON_CREDS_SPECIFIERS,
|
|
{}
|
|
};
|
|
|
|
assert(i);
|
|
assert(format);
|
|
assert(ret);
|
|
|
|
return specifier_printf(format, max_length, table, root, i, ret);
|
|
}
|