From f6613445d97a2c0fba2a5ea8578c3168963b9d59 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Mon, 2 Nov 2026 18:49:31 +0000 Subject: [PATCH] AGENTS.md: do not insist on clang-tidy clang-tidy is extremely finicky and requires an exact version in order to work, and fails otherwise. When that happens the bots go crazy and try to do the most stupid things to try and get a version compatible with the config. Reword the rule so that hopefully they stop doing that. --- AGENTS.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index c5efdb45aa0..7af449680e7 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -49,8 +49,9 @@ display. This is critical for diagnosing build and test failures. ## clang-tidy -- After changing C code, always run clang-tidy for the affected code and fix every finding before -committing. CI runs the same checks and fails on any warning. +- After changing C code, try to run clang-tidy for the affected code and fix every finding before +committing, if a compatible version is already available (skip it if not, never try to obtain a new version yourself). +CI runs the same checks and fails on any warning. - meson.build defines a test named `clang-tidy-` for every `.c` and `.h` file in its `sources` list. The `.h` file with the same name next to a `.c` file in the list gets a test as well. Other files have no test of their own, for example `src/basic/macro.h` and the sources of NSS and PAM modules.