From d229e8b083dd086b92ba6009176b9aa036e714cd Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Tue, 3 Nov 2026 15:10:24 +0100 Subject: [PATCH] libsystemd-network: comment bare literal arguments docs/CODING_STYLE.md asks for a /* name= */ comment whenever NULL or another value meaning "unset" is passed to a function. Add it wherever a bare NULL, 0, false or true is passed for a parameter with a telling name. Mechanical, generated by tools/check-argument-comments.py --fix. --- src/libsystemd-network/test-dhcp-server.c | 2 +- src/libsystemd-network/test-dhcp6-client.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-network/test-dhcp-server.c b/src/libsystemd-network/test-dhcp-server.c index db2cf0c7d48..1a5cb7ec34b 100644 --- a/src/libsystemd-network/test-dhcp-server.c +++ b/src/libsystemd-network/test-dhcp-server.c @@ -493,7 +493,7 @@ TEST(dhcp_server_static_lease_special_addresses) { _cleanup_(sd_dhcp_server_unrefp) sd_dhcp_server *server = NULL; ASSERT_OK(sd_dhcp_server_new(&server, 4242)); ASSERT_OK(sd_dhcp_server_configure_pool(server, &(struct in_addr) { htobe32(INADDR_LOOPBACK) }, - 8, 0, 0)); + 8, /* offset= */ 0, /* size= */ 0)); sd_dhcp_client_id client_id_subnet = { .size = 7, diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c index dc613ad1ebd..ac9fc97c0de 100644 --- a/src/libsystemd-network/test-dhcp6-client.c +++ b/src/libsystemd-network/test-dhcp6-client.c @@ -411,7 +411,7 @@ TEST(lease_timezone) { /* "UTC" in the main test messages bypasses the tzfile check in * verify_timezone(); exercise the validation with invalid inputs. */ - ASSERT_ERROR(dhcp6_lease_set_timezone(lease, (const uint8_t *) "", 0), EINVAL); + ASSERT_ERROR(dhcp6_lease_set_timezone(lease, (const uint8_t *) "", /* optlen= */ 0), EINVAL); ASSERT_ERROR(dhcp6_lease_set_timezone(lease, (const uint8_t *) "UTC\0", 4), EINVAL); ASSERT_ERROR(dhcp6_lease_set_timezone(lease, (const uint8_t *) "/etc/passwd", 11), EINVAL); ASSERT_ERROR(dhcp6_lease_set_timezone(lease, (const uint8_t *) "../passwd", 9), EINVAL);