From d0aec7d4daa0670411613de4e9c3cd444a8a216f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sun, 12 Jun 2022 20:51:41 +0200 Subject: [PATCH] sd-id128: avoid an unnecessary function call in inline helper When optimizing, the compiler will most likely replace the call to memcmp(), but at -O0, the code that is emitted builds the call preamble and does the call. Let's use the same pattern as with sd_id128_is_null() and sd_id128_is_allf() and avoid the call. --- src/systemd/sd-id128.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemd/sd-id128.h b/src/systemd/sd-id128.h index f7d3244bb38..2aa41623cef 100644 --- a/src/systemd/sd-id128.h +++ b/src/systemd/sd-id128.h @@ -116,7 +116,7 @@ int sd_id128_get_boot_app_specific(sd_id128_t app_id, sd_id128_t *ret); #a #b #c #d "-" #e #f "-" #g #h "-" #i #j "-" #k #l #m #n #o #p _sd_pure_ static __inline__ int sd_id128_equal(sd_id128_t a, sd_id128_t b) { - return memcmp(&a, &b, 16) == 0; + return a.qwords[0] == b.qwords[0] && a.qwords[1] == b.qwords[1]; } _sd_pure_ static __inline__ int sd_id128_is_null(sd_id128_t a) {