From cc7ac73ddbb36f7a6c324cf36febb3d5b0501947 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 5 Oct 2021 19:56:46 +0200 Subject: [PATCH 1/2] shared/dissect-image: reword debug message I read the message and initially thought that there's some bug in time subtraction. Let's make it clear that the message is about what we'll do in the future, and not a report on how we waited up until now. --- src/shared/dissect-image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/dissect-image.c b/src/shared/dissect-image.c index 74cebe1f711..6b2289defa1 100644 --- a/src/shared/dissect-image.c +++ b/src/shared/dissect-image.c @@ -546,7 +546,7 @@ static int device_wait_for_initialization_harder( (void) sd_device_get_sysname(device, &sn); log_device_debug(device, - "Waiting for device '%s' to initialize for %s.", strna(sn), FORMAT_TIMESPAN(left, 0)); + "Will wait up to %s for '%s' to initialize…", FORMAT_TIMESPAN(left, 0), strna(sn)); } if (left != USEC_INFINITY) From 384c6207669eb0d92aa0043dbc01957c6c7ff41e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 12 Oct 2021 19:46:25 +0200 Subject: [PATCH 2/2] coredumpctl: stop truncating information about coredump MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the changes to limit that print 'Found module …' over and over, we were hitting the journal field message limit, effectively truncating the info output. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1998488. --- src/coredump/coredumpctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/coredump/coredumpctl.c b/src/coredump/coredumpctl.c index 2eaa56a4fd9..3f6537faeec 100644 --- a/src/coredump/coredumpctl.c +++ b/src/coredump/coredumpctl.c @@ -563,6 +563,8 @@ static int print_info(FILE *file, sd_journal *j, bool need_space) { assert(file); assert(j); + (void) sd_journal_set_data_threshold(j, 0); + SD_JOURNAL_FOREACH_DATA(j, d, l) { RETRIEVE(d, l, "MESSAGE_ID", mid); RETRIEVE(d, l, "COREDUMP_PID", pid);