From bc97dd19ef66b7356537c09006ecd7ec9f6c69bf Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 4 Nov 2026 10:35:48 +0100 Subject: [PATCH] dbus-cgroup: fix swapped arguments in "not normalized" error messages The IO*Max=, IODeviceWeight= and IODeviceLatencyTargetSec= handlers passed the property name and the path in the wrong order, resulting in messages such as "Path 'IOReadBandwidthMax' specified in /var/= is not normalized." --- src/core/dbus-cgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c index b447cea561b..a4ce9d416fb 100644 --- a/src/core/dbus-cgroup.c +++ b/src/core/dbus-cgroup.c @@ -1253,7 +1253,7 @@ int bus_cgroup_set_property( while ((r = sd_bus_message_read(message, "(st)", &path, &u64)) > 0) { if (!path_is_normalized(path)) - return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", name, path); + return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", path, name); if (!UNIT_WRITE_FLAGS_NOOP(flags)) { CGroupIODeviceLimit *a = NULL; @@ -1336,7 +1336,7 @@ int bus_cgroup_set_property( while ((r = sd_bus_message_read(message, "(st)", &path, &weight)) > 0) { if (!path_is_normalized(path)) - return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", name, path); + return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", path, name); if (!CGROUP_WEIGHT_IS_OK(weight) || weight == CGROUP_WEIGHT_INVALID) return sd_bus_error_set(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "IODeviceWeight= value out of range"); @@ -1413,7 +1413,7 @@ int bus_cgroup_set_property( while ((r = sd_bus_message_read(message, "(st)", &path, &target)) > 0) { if (!path_is_normalized(path)) - return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", name, path); + return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Path '%s' specified in %s= is not normalized.", path, name); if (!UNIT_WRITE_FLAGS_NOOP(flags)) { CGroupIODeviceLatency *a = NULL;