diff --git a/man/crypttab.xml b/man/crypttab.xml index 1f779395899..ea5dd5ea694 100644 --- a/man/crypttab.xml +++ b/man/crypttab.xml @@ -232,6 +232,13 @@ activation (e.g. via a file in /run/, generated by a service running before activation), and shall be removed after use. Defaults to off. + Note that this option only applies to a key file explicitly configured in the third field, and + has no effect on key files that are automatically discovered in + /etc/cryptsetup-keys.d/ and /run/cryptsetup-keys.d/. The + latter are considered shared resources that are not owned by an individual volume, and hence are never + erased. To erase an automatically discovered key file, configure its path explicitly in the third + field. + diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index dd3255aaa3b..2dc0162d272 100644 --- a/src/cryptsetup/cryptsetup.c +++ b/src/cryptsetup/cryptsetup.c @@ -2433,6 +2433,9 @@ static int verb_attach(int argc, char *argv[], void *userdata) { /* A delicious drop of snake oil */ (void) safe_mlockall(MCL_CURRENT|MCL_FUTURE|MCL_ONFAULT); + /* Only erase key files explicitly configured on the command line, never the ones we + * auto-discover in /etc/cryptsetup-keys.d/ and /run/cryptsetup-keys.d/: those are shared + * resources not owned by an individual volume. (key_file is NULL when auto-discovery is used.) */ if (key_file && arg_keyfile_erase) destroy_key_file = key_file; /* let's get this baby erased when we leave */