diff --git a/src/import/export-raw.c b/src/import/export-raw.c index 5c9c2bbcd94..f4253962615 100644 --- a/src/import/export-raw.c +++ b/src/import/export-raw.c @@ -120,7 +120,7 @@ static void raw_export_report_progress(RawExport *e) { if (!ratelimit_below(&e->progress_ratelimit)) return; - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_info("Exported %u%%.", percent); e->last_percent = percent; diff --git a/src/import/export-tar.c b/src/import/export-tar.c index 2f54cd81148..9e92badfef3 100644 --- a/src/import/export-tar.c +++ b/src/import/export-tar.c @@ -131,7 +131,7 @@ static void tar_export_report_progress(TarExport *e) { if (!ratelimit_below(&e->progress_ratelimit)) return; - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_info("Exported %u%%.", percent); e->last_percent = percent; diff --git a/src/import/import-raw.c b/src/import/import-raw.c index 2db3198ba61..f7ed163d864 100644 --- a/src/import/import-raw.c +++ b/src/import/import-raw.c @@ -147,7 +147,7 @@ static void raw_import_report_progress(RawImport *i) { if (!ratelimit_below(&i->progress_ratelimit)) return; - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_info("Imported %u%%.", percent); i->last_percent = percent; diff --git a/src/import/import-tar.c b/src/import/import-tar.c index 8c184578169..90202709ecc 100644 --- a/src/import/import-tar.c +++ b/src/import/import-tar.c @@ -148,7 +148,7 @@ static void tar_import_report_progress(TarImport *i) { if (!ratelimit_below(&i->progress_ratelimit)) return; - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_info("Imported %u%%.", percent); i->last_percent = percent; diff --git a/src/import/importd.c b/src/import/importd.c index cb5156bf063..e1a1ddc2ee1 100644 --- a/src/import/importd.c +++ b/src/import/importd.c @@ -598,7 +598,7 @@ static int manager_on_notify(sd_event_source *s, int fd, uint32_t revents, void r = parse_percent(p); if (r < 0) { - log_warning("Got invalid percent value, ignoring."); + log_warning("Got invalid percent value '%s', ignoring.", p); return 0; } diff --git a/src/import/pull-raw.c b/src/import/pull-raw.c index e96be4dd7db..66c3f656656 100644 --- a/src/import/pull-raw.c +++ b/src/import/pull-raw.c @@ -232,7 +232,7 @@ static void raw_pull_report_progress(RawPull *i, RawProgress p) { assert_not_reached(); } - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_debug("Combined progress %u%%", percent); } diff --git a/src/import/pull-tar.c b/src/import/pull-tar.c index 2db25192da1..c32fc290143 100644 --- a/src/import/pull-tar.c +++ b/src/import/pull-tar.c @@ -192,7 +192,7 @@ static void tar_pull_report_progress(TarPull *i, TarProgress p) { assert_not_reached(); } - sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); + sd_notifyf(false, "X_IMPORT_PROGRESS=%u%%", percent); log_debug("Combined progress %u%%", percent); } diff --git a/src/systemctl/systemctl-show.c b/src/systemctl/systemctl-show.c index 4ec2a7c9413..963ba69ab6e 100644 --- a/src/systemctl/systemctl-show.c +++ b/src/systemctl/systemctl-show.c @@ -1996,6 +1996,7 @@ static int show_one( bool *ellipsized) { static const struct bus_properties_map property_map[] = { + { "Id", "s", NULL, offsetof(UnitStatusInfo, id) }, { "LoadState", "s", NULL, offsetof(UnitStatusInfo, load_state) }, { "ActiveState", "s", NULL, offsetof(UnitStatusInfo, active_state) }, { "FreezerState", "s", NULL, offsetof(UnitStatusInfo, freezer_state) }, diff --git a/test/test-functions b/test/test-functions index e2d3f109a21..b054892e172 100644 --- a/test/test-functions +++ b/test/test-functions @@ -472,6 +472,8 @@ run_qemu() { local CONSOLE=ttyS0 + # Reset the boot counter, if present + rm -f "${initdir:?}/var/tmp/.systemd_reboot_count" rm -f "$initdir"/{testok,failed,skipped} # make sure the initdir is not mounted to avoid concurrent access cleanup_initdir @@ -645,6 +647,8 @@ run_qemu() { # success), or 1 if nspawn is not available. run_nspawn() { [[ -d /run/systemd/system ]] || return 1 + # Reset the boot counter, if present + rm -f "${initdir:?}/var/tmp/.systemd_reboot_count" rm -f "${initdir:?}"/{testok,failed,skipped} local nspawn_cmd=() @@ -3356,9 +3360,6 @@ test_run() { local test_id="${1:?}" mount_initdir - # Reset the boot counter, if present - rm -f "${initdir:?}/var/tmp/.systemd_reboot_count" - if ! get_bool "${TEST_NO_QEMU:=}"; then if run_qemu "$test_id"; then check_result_qemu || { echo "qemu test failed"; return 1; } diff --git a/test/units/testsuite-44.service b/test/units/testsuite-44.service index e0d4a8c18d0..4dffdeab94a 100644 --- a/test/units/testsuite-44.service +++ b/test/units/testsuite-44.service @@ -10,4 +10,3 @@ After=systemd-journald@foobar.socket systemd-journald-varlink@foobar.socket ExecStartPre=rm -f /failed /testok ExecStart=/usr/lib/systemd/tests/testdata/units/%N.sh Type=oneshot -LogTarget=foobar diff --git a/test/units/testsuite-64.sh b/test/units/testsuite-64.sh index d223f52b6a2..81edb0ab7a1 100755 --- a/test/units/testsuite-64.sh +++ b/test/units/testsuite-64.sh @@ -756,7 +756,7 @@ EOF udevadm wait --settle --timeout=30 "/dev/disk/by-uuid/deadbeef-dead-dead-beef-11111111111$i" "/dev/disk/by-label/encdisk$i" # Add the device into /etc/crypttab, reload systemd, and then activate # the device so we can create a filesystem on it later - echo "encbtrfs$i UUID=deadbeef-dead-dead-beef-11111111111$i /etc/btrfs_keyfile luks,noearly" >>/etc/crypttab + echo "encbtrfs$i UUID=deadbeef-dead-dead-beef-11111111111$i /etc/btrfs_keyfile luks" >>/etc/crypttab systemctl daemon-reload systemctl start "systemd-cryptsetup@encbtrfs$i" done