From 407139ae92e527ff66a7302165d3690eb24ac3f9 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 3 Sep 2025 10:38:59 +0200 Subject: [PATCH] bootctl: output a more precise log message when updating existing EFI vars --- src/bootctl/bootctl-install.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/bootctl/bootctl-install.c b/src/bootctl/bootctl-install.c index 89a82192f87..b70e945ca7a 100644 --- a/src/bootctl/bootctl-install.c +++ b/src/bootctl/bootctl-install.c @@ -906,10 +906,17 @@ static int install_variables( return graceful ? 0 : r; } - if (first || r == 0) { - r = efi_add_boot_option(slot, pick_efi_boot_option_description(), - part, pstart, psize, - uuid, path); + bool existing = r > 0; + + if (first || !existing) { + r = efi_add_boot_option( + slot, + pick_efi_boot_option_description(), + part, + pstart, + psize, + uuid, + path); if (r < 0) { int level = graceful ? arg_quiet ? LOG_DEBUG : LOG_INFO : LOG_ERR; const char *skip = graceful ? ", skipping" : ""; @@ -919,7 +926,9 @@ static int install_variables( return graceful ? 0 : r; } - log_info("Created EFI boot entry \"%s\".", pick_efi_boot_option_description()); + log_info("%s EFI boot entry \"%s\".", + existing ? "Updated" : "Created", + pick_efi_boot_option_description()); } return insert_into_order(slot, first);