Problem: An invalid nested expression such as "echo (0!)" gives
"E110: Missing ')'" although the ")" is there, and does not say
where the expression is not valid.
Solution: When text follows the expression, add it to the E110 message, as
E697 does for a List (zuloloxi).
Without parentheses "echo 0!" already gives E15 with the text "!". When
nothing follows the expression the ")" is really missing and the message
is as before.
related: vim/vim#17602
closes: vim/vim#21607https://github.com/vim/vim/commit/d06691450ab0dc2ea72a997f8426002f66da2ac2
Co-authored-by: zuloloxi <10588750+zuloloxi@users.noreply.github.com>
Problem:
- `json_encode()` leaks the conversion stack if a dict key nested more
than 8 levels deep is invalid UTF-8, and leaks the string of an
invalid special string (`v:msgpack_types.string`).
- Lua conversion passes the total stack size to `lua_checkstack()`,
which expects the extra slots, so it fails at half the real limit.
- If `nlua_push_typval()` fails, the Lua stack is not restored: e.g.
`vim.g.x` returns part of the half-built value.
Solution:
- `encode_vim_to_*()` owns the conversion state, so converter macros
may return at any point.
- Check the Lua stack once per value, for 3 extra slots.
- Restore the Lua stack and push nil on failure.
"git" is not informed that all Vim files in vim_na_files.txt are N/A
to Neovim.
Git requires "exclude" pathspec (:^) to use vim_na_files.txt.
pathspec supports globs and character ranges.
Migrate regexs from vim_na_regexp.txt to optimize grep.
----
Some "*cp125[01]*" files from Vim remain applicable to Neovim.
Do not auto-N/A their patches.
----
https://git-scm.com/docs/gitglossary#Documentation/gitglossary.txt-pathspec
* build(vim-patch): v9.1.0500 is n/a
* build(vim-patch): n/a change in src/po/Make*
Nvim uses "TARGET_FILE:nvim_bin" in CMake.
* build(vim-patch): runtime/doc/pi_netrw.txt should be n/a
Minor differences between netrw docs are not relevant to Neovim.
Vim keeps pi_netrw.txt to add/override few lines
but it is partly "behind" upstream netrw.
- runtime/doc/pi_netrw.txt
- runtime/pack/dist/opt/netrw/doc/netrw.txt
* build(vim-patch): track ':Tutor' patches
":Tutor" remains maintained based on recent Github issues
such that Neovim does not rely on Vim patches to fix its own
implementation.
Develepor may port Vim patches that fix Vim's implementation of ":Tutor"
but Vim and Neovim remain incompatible
after Neovim replace metadata JSON files with inline comments,
https://github.com/neovim/neovim/issues/38527 .
Vim and Neovim are not obligated to restrict their tutor files
in order to ensure 100% (backward) compatibility on both editors.
Both will use their exclusive and incompatible features to enhance
the user experience in ":Tutor".
Continue to track ":Tutor" patches to not discourage
contributors on both projects.
Target 6fa304f27d630f4c11c903a61d434f739230e8e1 .
* build(vim-patch): n/a tabpanel changes from v9.1.1391
https://github.com/neovim/neovim/pull/42121 broke "-L" and "-l"
for commits specific to 1 file
because majority of Vim commits are tagged
and "git log --tags --no-walk" is inconsistent for 1-file queries.
"git log --stdin --no-walk" does work so it's always required
regardless of additional formatting.
----
Tags v9.0.0055 and v9.0.0056 are on the same commit.
Detecting 1 of the tags resolves the other for "-L" and "-l".
Patch 9.0.0056 is N/A based on
commit e15f79c659 .
vim-patch.sh can't auto-detect v9.0.0056 yet.
----
TODO
Prevent developer from overwriting essential "--format=" flags
else vim-patch.sh produces invalid Git refs.
* build(vim-patch): n/a hunks from v9.0.1410
Detect patches for N/A translations.
https://github.com/neovim/neovim/pull/5622 remove some
non-UTF8 "po" files.
Nvim has different process for "mo" files.
* build(vim-patch): tojavascript.vim is n/a
N/A since https://github.com/neovim/neovim/pull/36505 .
* build(vim-patch): v9.0.1537 is n/a
PO_VIM_ variables are only for N/A tasks: "first_time", "*.pot".
"first_time" task has similar/identical shell commands to "*.pot" task.
* build(vim-patch): v8.2.5000 is n/a
Commit 36e3f4f4c4 removed the section
for "win32-compiling".
"$WSLENV" is defined outside of WSL based on my setup.
I never run Neovim on WSL beyond testing patches like this one.
* build(vim-patch): "--not-a-term" flag is n/a
Target v8.2.5084.
* build(vim-patch): v8.2.4282 should be n/a
"restricted-mode" is N/A since https://github.com/neovim/neovim/pull/11996
* build(vim-patch): v8.2.1858 is n/a
Vim9 "ret_.*()" return type functions are N/A.
* build(vim-patch): n/a tags for encryption docs
Commit title for those tags do not use the template "patch: vX.Y.Z"
compared to other tagged commits.
Instead of parsing the commmit title, check refs/tags/.
Treating Bash associative array as Set/Map data structure
does not scale for fast lookups.
If I run vim-patch.sh before sleeping,
then it should complete after 5 hours of sleep.
"grep -v -f <()" allows vim-patch.sh to complete within minute(s)
and reuses "list_vimpatch_numbers()" which generates the
Vim patch numbers, merged to Neovim.
* build(vim-patch): 1b7fbe726a4e7ad117bace7e40f5e0a286a2cd5b is n/a
"X11" section removed in e099b545be .
* build(vim-patch): n/a links in version9.txt
Patch "vX.Y.0000" modifies Table-of-Contents (TOC) for
"runtime/doc/version.*\.txt"
N/A.
Those version doc files remain relevant for "news.txt",
not the Vim version bump.
- no subshell just for git log
- start lookup for "missing vim-patch: commits" on
commit 38fb835854
- remove "vim-patch:" prefix for keys in "$tokens" array
* build(vim-patch): 06a604dc8ed0159773e0d6515a239f22e0cf0b5a is n/a
runtime/xdg.vim is always N/A.
* build(vim-patch): 07dc94023ca9e6cecb139d855814bda8a985d98c is n/a
GTK4 GUI is n/a.
* build(vim-patch): 3f53a2ce2fa96e865b9f4d2c818f34ccf9ff720f is n/a
server2client() is n/a.
* build(vim-patch): 44021be4852e665b06357d6739c4f00faa447b3d is n/a
* build(vim-patch): n/a tags from bc2141d27d74823a12a8c0b94262583b45edfed1
Nvim kept docs for command ":TOhtml", not the section for "2html.vim".
Vim9script rewrite makes the plugin N/A.
* build(vim-patch): v9.2.0723 is n/a
* build(vim-patch): v9.2.0875 is n/a
Nvim does not compile GTK4 for its GUI.
* build(vim-patch): v9.2.0912 is n/a
":hardcopy" has been N/A since v0.9.
I can't auto-N/A v9.2.0898 because of OS #ifdefs.
* build(vim-patch): v9.2.1109 is n/a
* build(vim-patch): v9.2.0198 is n/a
* build(vim-patch): v9.2.0248 is almost auto n/a
Regex "[^\s]" does not work to detect hunk for js_decode() as N/A.
"[^[:space:]]" works as an improvement replacement
since Vim help files use tabs.
https://git-scm.com/docs/git-log#Documentation/git-log.txt---word-diff-regexregex
* build(vim-patch): v9.2.0316 is n/a
All "netbeans" files are N/A.
* build(vim-patch): add n/a tags from v9.2.0386
* build(vim-patch): v9.2.404 is n/a
* build(vim-patch): n/a tags from v9.2.0407
* build(vim-patch): v9.2.507 is n/a
Treat comments for unused error codes as N/A
because the rest of the patch can be N/A.
Vim9 keywords and error messages are N/A.
Automation can sort "src/errors.h"
and detect unused/unsupported error codes to sync with Vim's error.h .
* build(vim-patch): fix vimhelp xfuncname
cfa8f9a3f285060152ebbdbf86fbc7aecf1dd756 has changes near:
> - If the BufRead* events allow you to edit a compressed file, the FileRead*
Update git-diff "xfuncname" to skip the above line
when searching for nearest "hunk header".
* build(vim-patch): f27e80a6e183a617dd885311871fd4eaa6075d16 is n/a
Nvim generates "runtime/syntax/vim/generated.vim"
based on "src/nvim/*.lua",
specifically "src/nvim/ex_cmds.lua" for Ex commands,
since https://github.com/neovim/neovim/pull/2288 .
* build(vim-patch): ee865249b1edd56e297f12025e11defb6a4bf445 is n/a
* build(vim-patch): a44ced5763d377c71c96562b894c1c026ba89328 is n/a
* build(vim-patch): v9.1.1564 is n/a
* build(vim-patch): v9.1.1743 is n/a
* build(vim-patch): v9.1.1745 is n/a
* build(vim-patch): 39acad46fa7bce974f2bb036843009b8f4669ff8 is n/a
colorresp plugin is n/a.
Vim added it v9.1.1703 and then removed it in v9.1.1757.
Nvim does not rely on Vimscript (API) to set 'v:term.*' variables
for the end-users terminal.
* build(vim-patch): v9.1.1795 is n/a
* build(vim-patch): 93d9d196ed3a70174ba5e790d9e36e0478e84a09 is n/a
X11 fonts for multi-byte feature is N/A.
* build(vim-patch): v9.2.0060 is n/a
Vim's implementation/support of Debug Adapter Protocol is N/A,
especially if it relies on Vim channels, JSON, JSON-RPC, etc.
https://github.com/neovim/neovim/issues/11732 has discussion
and status updates for Nvim's implementation.
* build(vim-patch): v9.2.0153 is n/a
Vim channel is N/A.
Nvim generates "runtime/syntax/vim/generated.vim"
based on "src/nvim/*.lua"
since https://github.com/neovim/neovim/pull/2288 .
This is a bit more boilerplate because of painful impedance mismatch (is
augroup names the root source of truth? is ids the source of truth? who
knows? what does truth even mean?), but show an error reflecting what
the caller actually tried (they passed in an invalid id, not a null
string)
"vim.pot" file and tasks are N/A.
"clean" task is N/A after migrating to CMake.
N/A patches:
- 59bd74ed4c9ab366182c93bdc430b186729abbad
- 5d552d652b0197063565ab937d30f92a9ed28545
- 3c8d32e4fc17b4b38b17d7c039ee6203d1b01078
Global variables with "_for_testing" suffix are modified
in "f_test_override()", N/A to Nvim.
If a test needs them, then port the relevant code outside
"f_test_override()" via LuaJIT C FFI.
Nvim implementation of ":TOhtml" fails on test_tohtml.vim
because they compare with the sample test files.
Customizing the sample files to pass Vim's test is maintenance burden.
Nvim has lua functional tests to skip Vim's tests.
Nvim's test Makefile computes NEW_TESTS, NEW_TESTS_RES, unlike Vim.
Likely N/A.
Following runtime/ files are N/A after Lua rewrite.
- runtime/autoload/tohtml.vim
- runtime/syntax/2html.vim
- runtime/plugin/tohtml.vim
Nvim uses utf8proc or an older process involving "src/unicode/"
and "download-unicode-files.sh" to decouple unicode characters
from "mbyte.c".
These unicode patches should be auto N/A but the diff hunk xfuncname
is wrong for utf_char2cells().
Is it because of the `#ifdef`?
Need a volunteer to inspect if these patches still have relevant
changes
Nvim
```c
/// same as utf_composinglike but operating on UCS-4 values
bool utf_iscomposing(int c1, int c2, GraphemeState *state)
{
return (!utf8proc_grapheme_break_stateful(c1, c2, state)
|| arabic_combine(c1, c2));
}
```
Vim
```c
/*
* Return TRUE if "c" is a composing UTF-8 character. This means it will be
* drawn on top of the preceding character.
* Based on code from Markus Kuhn.
*/
int
utf_iscomposing(int c)
{
// Sorted list of non-overlapping intervals.
// Generated by ../runtime/tools/unicode.vim.
static struct interval combining[] =
{
{0x0300, 0x036f},
{0x0483, 0x0489},
{0x0591, 0x05bd},
// ...
{0x0300, 0x036f},
{0x0483, 0x0489},
{0x0591, 0x05bd},
};
return intable(combining, sizeof(combining), c);
}
```
termopen() and term_start() are not 1-1 because of Windows.
See Vim's ":h job_start".
```
{command} can be a String. This works best on MS-Windows. On
Unix it is split up in white space separated parts to be
passed to execvp(). Arguments in double quotes can contain
white space.
{command} can be a List, where the first item is the
executable and further items are the arguments. All items are
converted to String. This works best on Unix.
```
Problem:
Claude and friends love to sprinkle advertisements in commit messages.
Solution:
Allow a generic "AI-assisted" token only.
Reject useless mentions of AI services, sessions, and other cringe.
Disclosure: This PR was authored by an sapient turnip , raised in
moist, fluffy soil, tilled by the blurry wings of a hummingbird.
