mirror of
https://github.com/moby/moby.git
synced 2026-07-09 16:17:28 +00:00
5e4e34a966
Migrated using
find . -type f -name "*_test.go" |
xargs gofmt -w \
-r "assert.Check(t, strings.Contains(a, b)) -> assert.Check(t, is.Contains(a, b))"
find . -type f -name "*_test.go" |
xargs gofmt -w \
-r "assert.Assert(t, strings.Contains(a, b)) -> assert.Assert(t, is.Contains(a, b))"
Using a boolean in assert.Assert or assert.Check results in error
messages that don't contain the actual problematic string, and when
running the integration suite on an actual machine (where the source
code parsing doesn't work) this makes it almost impossible to figure out
what the actual error is.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
90 lines
3.1 KiB
Go
90 lines
3.1 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/runconfig"
|
|
"github.com/docker/docker/testutil"
|
|
"github.com/docker/docker/testutil/request"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
type DockerAPISuite struct {
|
|
ds *DockerSuite
|
|
}
|
|
|
|
func (s *DockerAPISuite) TearDownTest(ctx context.Context, c *testing.T) {
|
|
s.ds.TearDownTest(ctx, c)
|
|
}
|
|
|
|
func (s *DockerAPISuite) OnTimeout(c *testing.T) {
|
|
s.ds.OnTimeout(c)
|
|
}
|
|
|
|
func (s *DockerAPISuite) TestAPIOptionsRoute(c *testing.T) {
|
|
resp, _, err := request.Do(testutil.GetContext(c), "/", request.Method(http.MethodOptions))
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, resp.StatusCode, http.StatusOK)
|
|
}
|
|
|
|
func (s *DockerAPISuite) TestAPIGetEnabledCORS(c *testing.T) {
|
|
res, body, err := request.Get(testutil.GetContext(c), "/version")
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, res.StatusCode, http.StatusOK)
|
|
body.Close()
|
|
// TODO: @runcom incomplete tests, why old integration tests had this headers
|
|
// and here none of the headers below are in the response?
|
|
// c.Log(res.Header)
|
|
// assert.Equal(c, res.Header.Get("Access-Control-Allow-Origin"), "*")
|
|
// assert.Equal(c, res.Header.Get("Access-Control-Allow-Headers"), "Origin, X-Requested-With, Content-Type, Accept, X-Registry-Auth")
|
|
}
|
|
|
|
func (s *DockerAPISuite) TestAPIClientVersionOldNotSupported(c *testing.T) {
|
|
if testEnv.DaemonInfo.OSType != runtime.GOOS {
|
|
c.Skip("Daemon platform doesn't match test platform")
|
|
}
|
|
|
|
major, minor, _ := strings.Cut(testEnv.DaemonVersion.MinAPIVersion, ".")
|
|
vMinInt, err := strconv.Atoi(minor)
|
|
assert.NilError(c, err)
|
|
vMinInt--
|
|
version := fmt.Sprintf("%s.%d", major, vMinInt)
|
|
|
|
resp, body, err := request.Get(testutil.GetContext(c), "/v"+version+"/version")
|
|
assert.NilError(c, err)
|
|
defer body.Close()
|
|
assert.Equal(c, resp.StatusCode, http.StatusBadRequest)
|
|
expected := fmt.Sprintf("client version %s is too old. Minimum supported API version is %s, please upgrade your client to a newer version", version, testEnv.DaemonVersion.MinAPIVersion)
|
|
b, err := request.ReadBody(body)
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, getErrorMessage(c, b), expected)
|
|
}
|
|
|
|
func (s *DockerAPISuite) TestAPIErrorJSON(c *testing.T) {
|
|
httpResp, body, err := request.Post(testutil.GetContext(c), "/containers/create", request.JSONBody(struct{}{}))
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, httpResp.StatusCode, http.StatusBadRequest)
|
|
assert.Assert(c, is.Contains(httpResp.Header.Get("Content-Type"), "application/json"))
|
|
b, err := request.ReadBody(body)
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, getErrorMessage(c, b), runconfig.ErrEmptyConfig.Error())
|
|
}
|
|
|
|
func (s *DockerAPISuite) TestAPIErrorNotFoundJSON(c *testing.T) {
|
|
// 404 is a different code path to normal errors, so test separately
|
|
httpResp, body, err := request.Get(testutil.GetContext(c), "/notfound", request.JSON)
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, httpResp.StatusCode, http.StatusNotFound)
|
|
assert.Assert(c, is.Contains(httpResp.Header.Get("Content-Type"), "application/json"))
|
|
b, err := request.ReadBody(body)
|
|
assert.NilError(c, err)
|
|
assert.Equal(c, getErrorMessage(c, b), "page not found")
|
|
}
|