Sebastiaan van Stijn e55897977c daemon/graphdriver: simplify Checker, remove NewFsChecker, NewDefaultChecker ...

The Checker interface was introduced in 1ba05cdb6a
as an optimization to allow passing a simplified check for situations that
don't require mountinfo.Mounted to be executed (as that may result in parsing
 `/proc/self/mountinfo`).

The Checker was defined as an interface with a single `IsMounted` method,
possibly with the intent to allow for additional kind of checks to be added.
No new additions were made since its inception 9 Years ago, and if a need would
arrive, could probably be implemented as part of the check.

This patch simplifies the definition to a function, removing the need to
implement a wrapper struct just to satisfy the interface. The `Checker`
type definition is somewhat redundant, but is kept to have a place to
provide GoDoc.

The `NewFsChecker` and `NewDefaultChecker` utilities are removed as part
of this change, favoring a local definition for storage-drivers that
used them.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2024-07-01 19:15:26 +02:00

..

cluster

fix some gofmt issues reported by goreportcard

2024-06-27 23:02:00 +02:00

config

daemon/config: gofumpt

2024-06-27 23:18:47 +02:00

containerd

daemon/containerd: gofumpt

2024-06-27 23:18:47 +02:00

events

migrate to new github.com/distribution/reference module

2023-09-05 12:09:26 +02:00

graphdriver

daemon/graphdriver: simplify Checker, remove NewFsChecker, NewDefaultChecker

2024-07-01 19:15:26 +02:00

images

daemon: Emit Image Create event when image is built

2024-06-17 14:05:12 +02:00

initlayer

remove some remaining pre-go1.17 build-tags

2023-08-24 17:51:07 +02:00

internal

daemon/internal/fstype: make FsMagic values not platform-dependent

2024-07-01 19:15:26 +02:00

links

…

listeners

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

logger

daemon/logger, volume/drivers: remove redundant import-aliases

2024-06-30 19:22:17 +02:00

names

…

network

runconfig: deprecate IsPreDefinedNetwork

2024-06-20 11:10:54 +02:00

snapshotter

daemon/graphdriver: simplify Checker, remove NewFsChecker, NewDefaultChecker

2024-07-01 19:15:26 +02:00

stats

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

testdata

…

apparmor_default_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

apparmor_default.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

archive_tarcopyoptions_unix.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

archive_tarcopyoptions_windows.go

…

archive_tarcopyoptions.go

…

archive_unix.go

api/types: move ContainerPathStat to api/types/container

2024-06-10 10:20:45 +02:00

archive_windows.go

api/types: move ContainerPathStat to api/types/container

2024-06-10 10:20:45 +02:00

archive.go

api/types: move ContainerPathStat to api/types/container

2024-06-10 10:20:45 +02:00

attach.go

refactor: rename attach config var

2024-05-24 21:32:18 +00:00

auth.go

…

build.go

daemon: Emit Image Create event when image is built

2024-06-17 14:05:12 +02:00

cdi.go

Update container-device-interface to v0.6.2

2023-11-04 01:00:19 +01:00

changes.go

…

checkpoint.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

cluster.go

api/types: migrate NetworkResource to api/types/network

2024-06-04 17:44:46 +02:00

commit.go

migrate to new github.com/distribution/reference module

2023-09-05 12:09:26 +02:00

configs_linux.go

…

configs_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

configs_windows.go

…

configs.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

container_linux.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

container_operations_test.go

libnet: remove Endpoint.myAliases

2023-12-19 10:20:38 +01:00

container_operations_unix.go

Merge pull request #48008 from thaJeztah/deprecate_runconfig_DefaultDaemonNetworkMode

2024-06-18 14:13:07 +02:00

container_operations_windows.go

daemon: rename variables that shadowed imports

2024-06-17 11:06:06 +02:00

container_operations.go

runconfig: deprecate DefaultDaemonNetworkMode, move to daemon/network

2024-06-17 17:32:56 +02:00

container_unix_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

container_windows.go

…

container.go

runconfig: deprecate SetDefaultNetModeIfBlank

2024-06-17 00:26:46 +02:00

containerfs_linux.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

content.go

daemon: configureLocalContentStore: return concrete types

2023-07-18 14:18:42 +02:00

create_unix.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

create_windows.go

volumes/subpath: Plumb context

2024-01-19 17:32:21 +01:00

create.go

runconfig: deprecate SetDefaultNetModeIfBlank

2024-06-17 00:26:46 +02:00

daemon_linux_test.go

fix duplicate words (dupwords)

2024-03-07 10:57:03 +01:00

daemon_linux.go

Revert "Internal resolver for default bridge network"

2024-06-17 20:19:20 +01:00

daemon_test.go

daemon: add ULA prefix by default

2024-05-29 22:38:27 +02:00

daemon_unix_test.go

api: remove code for adjusting CPU shares (api < v1.19)

2024-02-06 18:44:33 +01:00

daemon_unix.go

daemon: add ULA prefix by default

2024-05-29 22:38:27 +02:00

daemon_unsupported.go

Revert "Internal resolver for default bridge network"

2024-06-17 20:19:20 +01:00

daemon_windows_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

daemon_windows.go

Merge pull request #48008 from thaJeztah/deprecate_runconfig_DefaultDaemonNetworkMode

2024-06-18 14:13:07 +02:00

daemon.go

daemon/graphdriver: remove support for external graphdriver plugins

2024-06-27 14:25:14 +02:00

debugtrap_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

debugtrap_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

debugtrap_windows.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

delete_test.go

Move StartedAt time to before starting the container

2024-03-12 16:20:21 +01:00

delete.go

pkg/containerfs: move to internal

2024-06-30 19:13:23 +02:00

dependency.go

…

devices.go

pkg/capabilities move to daemon/internal

2024-07-01 00:49:15 +02:00

disk_usage.go

api/types: move image options to api/types/image

2024-01-24 00:10:33 +01:00

errors_test.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

errors.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

events_test.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

events.go

Plumb context through info endpoint

2023-11-10 20:09:25 +00:00

exec_linux_test.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

exec_linux.go

Cleanup duplicate imports

2023-10-26 00:10:23 +01:00

exec_windows.go

daemon: read-copy-update the daemon config

2023-06-01 14:45:24 -04:00

exec.go

api/types: move ExecStartOptions to api/types/backend

2024-06-10 10:19:46 +02:00

export.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

health_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

health.go

Merge pull request #47936 from thaJeztah/api_types_container_types

2024-06-10 16:51:49 +02:00

id.go

Add otel support

2023-09-07 18:38:19 +00:00

image_service.go

Merge pull request #47679 from vvoland/c8d-multiplatform-push

2024-06-10 18:38:47 +02:00

info_unix_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

info_unix.go

(*Daemon).fillRootlessVersion: fix nil panic

2024-01-17 00:50:53 +09:00

info_windows.go

Plumb context through info endpoint

2023-11-10 20:09:25 +00:00

info.go

daemon: gofumpt

2024-06-27 23:18:47 +02:00

inspect_linux.go

api: remove code for ContainerInspect on api < v1.20

2024-02-06 18:44:43 +01:00

inspect_test.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

inspect_windows.go

api: remove code for ContainerInspect on api < v1.20

2024-02-06 18:44:43 +01:00

inspect.go

Update go:build comments to go1.21

2024-06-13 14:59:54 +02:00

keys_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

keys.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

kill.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

licensing_test.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

licensing.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

links.go

…

list_test.go

api/types: move ContainerListOptions to api/types/container

2023-10-12 11:29:24 +02:00

list_unix.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

list_windows.go

…

list.go

api/types/image: move GetImageOpts to api/types/backend

2024-01-22 20:45:21 +01:00

logdrivers_linux.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logdrivers_windows.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logs_test.go

…

logs.go

api/types: move ContainerLogsOptions to api/types/container

2023-10-12 11:30:12 +02:00

metrics_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

metrics_unsupported.go

daemon: read-copy-update the daemon config

2023-06-01 14:45:24 -04:00

metrics.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

monitor.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

mounts.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

names.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

network_windows.go

libnetwork: remove Network interface

2023-07-22 11:56:41 +02:00

network.go

daemon: gofumpt

2024-06-27 23:18:47 +02:00

nvidia_linux.go

pkg/capabilities move to daemon/internal

2024-07-01 00:49:15 +02:00

oci_linux_test.go

libnetwork: share a single datastore with drivers

2024-01-31 21:08:34 -05:00

oci_linux.go

libnet: SetKey: propagate traces from API to SetKey reexec

2024-06-14 15:25:08 +02:00

oci_opts.go

daemon: ensure OCI options play nicely together

2023-06-06 13:10:05 -04:00

oci_utils.go

daemon: ensure OCI options play nicely together

2023-06-06 13:10:05 -04:00

oci_windows_test.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

oci_windows.go

api/types/image: move GetImageOpts to api/types/backend

2024-01-22 20:45:21 +01:00

pause.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

prune.go

runconfig: deprecate IsPreDefinedNetwork

2024-06-20 11:10:54 +02:00

reload_test.go

daemon: add ULA prefix by default

2024-05-29 22:38:27 +02:00

reload_unix.go

daemon: consolidate runtimes config validation

2023-06-01 14:45:25 -04:00

reload_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

reload.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

rename.go

daemon: rename some inconsistent import aliases

2024-06-17 14:50:09 +02:00

resize_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

resize.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

restart.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

runtime_unix_test.go

vendor: containerd v1.7.12, and switch to dario.cat/mergo v1.0.0

2024-01-12 18:09:24 +01:00

runtime_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

runtime_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

seccomp_linux_test.go

seccomp: allow specifying a custom profile with --privileged

2024-06-11 03:37:54 +09:00

seccomp_linux.go

seccomp: allow specifying a custom profile with --privileged

2024-06-11 03:37:54 +09:00

seccomp_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

secrets_linux.go

…

secrets_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

secrets_windows.go

…

secrets.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

start_linux.go

libnet/driverapi: Add ctx to Join

2024-06-13 16:45:54 +02:00

start_notlinux.go

daemon: set libnetwork sandbox key w/o OCI hook

2024-01-19 20:23:12 +00:00

start_unix.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

start_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

start.go

Add containerd image ref to created containers

2024-06-17 14:45:17 +02:00

stats_collector.go

…

stats_unix.go

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

stats_windows.go

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

stats.go

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

stop.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

top_unix_test.go

daemon: use string-literals for easier grep'ing

2023-07-05 12:27:00 +02:00

top_unix.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

top_windows.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

unpause.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

update_linux_test.go

daemon: stop setting container resources to zero

2023-06-06 12:13:05 -04:00

update_linux.go

daemon: add nolint-comments for deprecated kernel-memory options, hooks

2024-04-15 17:55:47 +02:00

update_windows.go

…

update.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

volumes_linux_test.go

…

volumes_linux.go

…

volumes_unit_test.go

…

volumes_unix.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

volumes_windows.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

volumes.go

api/pre-1.44: Default ReadOnlyNonRecursive to true

2024-02-26 11:37:30 +01:00

wait.go

…

workdir.go

…