mirror of
https://github.com/moby/moby.git
synced 2026-07-19 22:12:22 +00:00
0823d76ec5
Using "familiarname" (e.g. "ubuntu") should be mostly done for presenting
image refernces to the user, but internally, we should use the canonical
format where possible ("docker.io/library/ubuntu").
There's still many places where we use the familiar (short) form, but
let's start with not converting references in the client.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
package client // import "github.com/docker/docker/client"
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types/image"
|
|
"github.com/docker/docker/api/types/registry"
|
|
"github.com/docker/docker/errdefs"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestImageCreateError(t *testing.T) {
|
|
client := &Client{
|
|
client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")),
|
|
}
|
|
_, err := client.ImageCreate(context.Background(), "reference", image.CreateOptions{})
|
|
assert.Check(t, is.ErrorType(err, errdefs.IsSystem))
|
|
}
|
|
|
|
func TestImageCreate(t *testing.T) {
|
|
const (
|
|
expectedURL = "/images/create"
|
|
expectedImage = "docker.io/test/my_image"
|
|
expectedTag = "sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
|
|
specifiedReference = "test/my_image:latest@" + expectedTag
|
|
expectedRegistryAuth = "eyJodHRwczovL2luZGV4LmRvY2tlci5pby92MS8iOnsiYXV0aCI6ImRHOTBid289IiwiZW1haWwiOiJqb2huQGRvZS5jb20ifX0="
|
|
)
|
|
|
|
client := &Client{
|
|
client: newMockClient(func(r *http.Request) (*http.Response, error) {
|
|
if !strings.HasPrefix(r.URL.Path, expectedURL) {
|
|
return nil, fmt.Errorf("Expected URL '%s', got '%s'", expectedURL, r.URL)
|
|
}
|
|
registryAuth := r.Header.Get(registry.AuthHeader)
|
|
if registryAuth != expectedRegistryAuth {
|
|
return nil, fmt.Errorf("%s header not properly set in the request. Expected '%s', got %s", registry.AuthHeader, expectedRegistryAuth, registryAuth)
|
|
}
|
|
|
|
query := r.URL.Query()
|
|
fromImage := query.Get("fromImage")
|
|
if fromImage != expectedImage {
|
|
return nil, fmt.Errorf("fromImage not set in URL query properly. Expected '%s', got %s", expectedImage, fromImage)
|
|
}
|
|
|
|
tag := query.Get("tag")
|
|
if tag != expectedTag {
|
|
return nil, fmt.Errorf("tag not set in URL query properly. Expected '%s', got %s", expectedTag, tag)
|
|
}
|
|
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: io.NopCloser(bytes.NewReader([]byte("body"))),
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
createResponse, err := client.ImageCreate(context.Background(), specifiedReference, image.CreateOptions{
|
|
RegistryAuth: expectedRegistryAuth,
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
response, err := io.ReadAll(createResponse)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err = createResponse.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if string(response) != "body" {
|
|
t.Fatalf("expected Body to contain 'body' string, got %s", response)
|
|
}
|
|
}
|