mirror of
https://github.com/moby/moby.git
synced 2026-08-09 01:21:37 +00:00
61646c8bfc
Removes workaround for https://github.com/moby/buildkit/issues/3797 now that the underlying issue is fixed. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
94 lines
3.0 KiB
Go
94 lines
3.0 KiB
Go
package image // import "github.com/docker/docker/integration/image"
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
containertypes "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/api/types/image"
|
|
"github.com/docker/docker/errdefs"
|
|
"github.com/docker/docker/integration/internal/container"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
"gotest.tools/v3/skip"
|
|
)
|
|
|
|
func TestRemoveImageOrphaning(t *testing.T) {
|
|
ctx := setupTest(t)
|
|
|
|
client := testEnv.APIClient()
|
|
|
|
imgName := strings.ToLower(t.Name())
|
|
|
|
// Create a container from busybox, and commit a small change so we have a new image
|
|
cID1 := container.Create(ctx, t, client, container.WithCmd(""))
|
|
commitResp1, err := client.ContainerCommit(ctx, cID1, containertypes.CommitOptions{
|
|
Changes: []string{`ENTRYPOINT ["true"]`},
|
|
Reference: imgName,
|
|
})
|
|
assert.NilError(t, err)
|
|
|
|
// verifies that reference now points to first image
|
|
resp, err := client.ImageInspect(ctx, imgName)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(resp.ID, commitResp1.ID))
|
|
|
|
// Create a container from created image, and commit a small change with same reference name
|
|
cID2 := container.Create(ctx, t, client, container.WithImage(imgName), container.WithCmd(""))
|
|
commitResp2, err := client.ContainerCommit(ctx, cID2, containertypes.CommitOptions{
|
|
Changes: []string{`LABEL Maintainer="Integration Tests"`},
|
|
Reference: imgName,
|
|
})
|
|
assert.NilError(t, err)
|
|
|
|
// verifies that reference now points to second image
|
|
resp, err = client.ImageInspect(ctx, imgName)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(resp.ID, commitResp2.ID))
|
|
|
|
// try to remove the image, should not error out.
|
|
_, err = client.ImageRemove(ctx, imgName, image.RemoveOptions{})
|
|
assert.NilError(t, err)
|
|
|
|
// check if the first image is still there
|
|
resp, err = client.ImageInspect(ctx, commitResp1.ID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(resp.ID, commitResp1.ID))
|
|
|
|
// check if the second image has been deleted
|
|
_, err = client.ImageInspect(ctx, commitResp2.ID)
|
|
assert.Check(t, is.ErrorContains(err, "No such image:"))
|
|
}
|
|
|
|
func TestRemoveByDigest(t *testing.T) {
|
|
skip.If(t, !testEnv.UsingSnapshotter(), "RepoDigests doesn't include tags when using graphdrivers")
|
|
|
|
ctx := setupTest(t)
|
|
client := testEnv.APIClient()
|
|
|
|
err := client.ImageTag(ctx, "busybox", "test-remove-by-digest:latest")
|
|
assert.NilError(t, err)
|
|
|
|
inspect, err := client.ImageInspect(ctx, "test-remove-by-digest")
|
|
assert.NilError(t, err)
|
|
|
|
id := ""
|
|
for _, ref := range inspect.RepoDigests {
|
|
if strings.Contains(ref, "test-remove-by-digest") {
|
|
id = ref
|
|
break
|
|
}
|
|
}
|
|
assert.Assert(t, id != "")
|
|
|
|
_, err = client.ImageRemove(ctx, id, image.RemoveOptions{})
|
|
assert.NilError(t, err, "error removing %s", id)
|
|
|
|
_, err = client.ImageInspect(ctx, "busybox")
|
|
assert.NilError(t, err, "busybox image got deleted")
|
|
|
|
inspect, err = client.ImageInspect(ctx, "test-remove-by-digest")
|
|
assert.Check(t, is.ErrorType(err, errdefs.IsNotFound))
|
|
assert.Check(t, is.DeepEqual(inspect, image.InspectResponse{}))
|
|
}
|