Albin Kerouanton 5295e88ceb daemon: rename: don't reload endpoint from datastore ...

Commit 8b7af1d0f added some code to update the DNSNames of all
endpoints attached to a sandbox by loading a new instance of each
affected endpoints from the datastore through a call to
`Network.EndpointByID()`.

This method then calls `Network.getEndpointFromStore()`, that in
turn calls `store.GetObject()`, which then calls `cache.get()`,
which calls `o.CopyTo(kvObject)`. This effectively creates a fresh
new instance of an Endpoint. However, endpoints are already kept in
memory by Sandbox, meaning we now have two in-memory instances of
the same Endpoint.

As it turns out, libnetwork is built around the idea that no two objects
representing the same thing should leave in-memory, otherwise breaking
mutex locking and optimistic locking (as both instances will have a drifting
version tracking ID -- dbIndex in libnetwork parliance).

In this specific case, this bug materializes by container rename failing
when applied a second time for a given container. An integration test is
added to make sure this won't happen again.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit 80c44b4b2e)
Signed-off-by: Albin Kerouanton <albinker@gmail.com>

2024-01-23 22:53:43 +01:00

..

cluster

daemon/cluster/executer: Add missing StartInterval

2024-01-22 15:23:27 +01:00

config

vendor: containerd v1.7.12, and switch to dario.cat/mergo v1.0.0

2024-01-12 18:09:24 +01:00

containerd

c8d/snapshot: Create any platform if not specified

2024-01-23 15:05:54 +01:00

events

migrate to new github.com/distribution/reference module

2023-09-05 12:09:26 +02:00

graphdriver

graphdriver/copy: faster copy of hard links

2023-11-13 18:22:03 +00:00

images

Implement GetLayerFolders for the containerd image store

2024-01-17 16:29:28 +01:00

initlayer

remove some remaining pre-go1.17 build-tags

2023-08-24 17:51:07 +02:00

links

…

listeners

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

logger

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

names

…

network

Remove generated MAC addresses on restart.

2024-01-22 19:51:54 +01:00

snapshotter

c8d/mount: Use ref-counted mounter by default

2024-01-18 15:38:51 +01:00

stats

Make one-shot stats faster

2023-09-27 14:10:23 +08:00

testdata

…

apparmor_default_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

apparmor_default.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

archive_tarcopyoptions_unix.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

archive_tarcopyoptions_windows.go

…

archive_tarcopyoptions.go

…

archive_unix.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

archive_windows.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

archive.go

…

attach.go

container: internalize InitAttachContext

2023-11-30 15:26:53 +01:00

auth.go

…

cdi.go

Update container-device-interface to v0.6.2

2023-11-04 01:00:19 +01:00

changes.go

…

checkpoint.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

cluster.go

…

commit.go

migrate to new github.com/distribution/reference module

2023-09-05 12:09:26 +02:00

configs_linux.go

…

configs_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

configs_windows.go

…

configs.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

container_linux.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

container_operations_test.go

libnet: remove Endpoint.myAliases

2023-12-19 10:20:38 +01:00

container_operations_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

container_operations_windows.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

container_operations.go

Merge pull request #47172 from thaJeztah/25.0_backport_fix-bad-http-code

2024-01-22 21:44:38 +01:00

container_unix_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

container_windows.go

…

container.go

daemon: no more IsAnonymousEndpoint

2023-12-19 10:20:38 +01:00

containerfs_linux.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

content.go

daemon: configureLocalContentStore: return concrete types

2023-07-18 14:18:42 +02:00

create_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

create_windows.go

…

create.go

add validation and migration for deprecated logentries driver

2023-12-13 01:10:05 +01:00

daemon_linux_test.go

tests: Move libnetwork/testutils to internal/testutils/netnsutils

2023-07-26 21:06:36 +02:00

daemon_linux.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

daemon_test.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

daemon_unix_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

daemon_unix.go

Merge pull request #46447 from akerouanton/api-predefined-networks

2023-11-24 12:26:48 +01:00

daemon_unsupported.go

daemon: read-copy-update the daemon config

2023-06-01 14:45:24 -04:00

daemon_windows_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

daemon_windows.go

Merge pull request #46447 from akerouanton/api-predefined-networks

2023-11-24 12:26:48 +01:00

daemon.go

fix "host-gateway-ip" label not set for builder workers

2024-01-23 15:59:09 +01:00

debugtrap_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

debugtrap_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

debugtrap_windows.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

delete_test.go

api/types: move ContainerCreateConfig, ContainerRmConfig to api/types/backend

2023-12-05 16:41:36 +01:00

delete.go

api/types: move ContainerCreateConfig, ContainerRmConfig to api/types/backend

2023-12-05 16:41:36 +01:00

dependency.go

…

devices.go

Remove need to set Capabilities for cdi driver

2023-05-16 17:07:58 +02:00

disk_usage.go

api/types: move ContainerListOptions to api/types/container

2023-10-12 11:29:24 +02:00

errors_test.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

errors.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

events_test.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

events.go

Plumb context through info endpoint

2023-11-10 20:09:25 +00:00

exec_linux_test.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

exec_linux.go

Cleanup duplicate imports

2023-10-26 00:10:23 +01:00

exec_windows.go

daemon: read-copy-update the daemon config

2023-06-01 14:45:24 -04:00

exec.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

export.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

health_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

health.go

daemon: stop checkpointing health probes to disk

2024-01-16 14:09:40 -05:00

id.go

Add otel support

2023-09-07 18:38:19 +00:00

image_service.go

Implement GetLayerFolders for the containerd image store

2024-01-17 16:29:28 +01:00

info_unix_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

info_unix.go

(*Daemon).fillRootlessVersion: fix nil panic

2024-01-17 00:50:53 +09:00

info_windows.go

Plumb context through info endpoint

2023-11-10 20:09:25 +00:00

info.go

daemon: work around go1.21 compiler bug

2024-01-04 00:02:39 +01:00

inspect_linux.go

api: Deprecate ContainerConfig.MacAddress

2023-10-25 22:55:59 +02:00

inspect_test.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

inspect_windows.go

…

inspect.go

daemon: only add short cid to aliases for custom networks

2024-01-23 17:09:11 +01:00

keys_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

keys.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

kill.go

daemon: kill: use log level to "warn" if container doesn't exit in time

2023-11-29 16:18:34 +01:00

licensing_test.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

licensing.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

links.go

…

list_test.go

api/types: move ContainerListOptions to api/types/container

2023-10-12 11:29:24 +02:00

list_unix.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

list_windows.go

…

list.go

api/types: move ContainerListOptions to api/types/container

2023-10-12 11:29:24 +02:00

logdrivers_linux.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logdrivers_windows.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logs_test.go

…

logs.go

api/types: move ContainerLogsOptions to api/types/container

2023-10-12 11:30:12 +02:00

metrics_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

metrics_unsupported.go

daemon: read-copy-update the daemon config

2023-06-01 14:45:24 -04:00

metrics.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

monitor.go

api/types: move ContainerCreateConfig, ContainerRmConfig to api/types/backend

2023-12-05 16:41:36 +01:00

mounts.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

names.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

network_windows.go

libnetwork: remove Network interface

2023-07-22 11:56:41 +02:00

network.go

libnet: remove Endpoint.myAliases

2023-12-19 10:20:38 +01:00

nvidia_linux.go

…

oci_linux_test.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

oci_linux.go

net=host: remove /var/run/docker/netns/default from OCI config

2024-01-18 18:09:52 +09:00

oci_opts.go

daemon: ensure OCI options play nicely together

2023-06-06 13:10:05 -04:00

oci_utils.go

daemon: ensure OCI options play nicely together

2023-06-06 13:10:05 -04:00

oci_windows_test.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

oci_windows.go

Root.Path for a process-isolated WCOW container must be the Volume GUID

2024-01-17 16:29:32 +01:00

pause.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

prune.go

api/types: move ContainerCreateConfig, ContainerRmConfig to api/types/backend

2023-12-05 16:41:36 +01:00

reload_test.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

reload_unix.go

daemon: consolidate runtimes config validation

2023-06-01 14:45:25 -04:00

reload_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

reload.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

rename.go

daemon: rename: don't reload endpoint from datastore

2024-01-23 22:53:43 +01:00

resize_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

resize.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

restart.go

daemon: daemon.containerRestart: don't cancel restart on context cancel

2023-10-24 12:56:45 +02:00

runtime_unix_test.go

vendor: containerd v1.7.12, and switch to dario.cat/mergo v1.0.0

2024-01-12 18:09:24 +01:00

runtime_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

runtime_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

seccomp_linux_test.go

container: split security options to a SecurityOptions struct

2023-04-29 00:03:37 +02:00

seccomp_linux.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

seccomp_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

secrets_linux.go

…

secrets_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

secrets_windows.go

…

secrets.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

start_unix.go

daemon: consolidate runtimes config validation

2023-06-01 14:45:25 -04:00

start_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

start.go

libcontainerd: create unstarted tasks

2024-01-10 13:50:26 -05:00

stats_collector.go

…

stats_unix.go

Make one-shot stats faster

2023-09-27 14:10:23 +08:00

stats_windows.go

Make one-shot stats faster

2023-09-27 14:10:23 +08:00

stats.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

stop.go

daemon: daemon.containerStop: use context.WithoutCancel

2023-10-20 17:44:30 +02:00

top_unix_test.go

daemon: use string-literals for easier grep'ing

2023-07-05 12:27:00 +02:00

top_unix.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

top_windows.go

daemon: format code with gofumpt

2023-06-29 00:33:03 +02:00

unpause.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

update_linux_test.go

daemon: stop setting container resources to zero

2023-06-06 12:13:05 -04:00

update_linux.go

daemon: stop setting container resources to zero

2023-06-06 12:13:05 -04:00

update_windows.go

…

update.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

volumes_linux_test.go

…

volumes_linux.go

…

volumes_unit_test.go

…

volumes_unix.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

volumes_windows.go

…

volumes.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

wait.go

…

workdir.go

…