mirror of
https://github.com/moby/moby.git
synced 2026-07-08 07:37:55 +00:00
5e4e34a966
Migrated using
find . -type f -name "*_test.go" |
xargs gofmt -w \
-r "assert.Check(t, strings.Contains(a, b)) -> assert.Check(t, is.Contains(a, b))"
find . -type f -name "*_test.go" |
xargs gofmt -w \
-r "assert.Assert(t, strings.Contains(a, b)) -> assert.Assert(t, is.Contains(a, b))"
Using a boolean in assert.Assert or assert.Check results in error
messages that don't contain the actual problematic string, and when
running the integration suite on an actual machine (where the source
code parsing doesn't work) this makes it almost impossible to figure out
what the actual error is.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
100 lines
4.1 KiB
Go
100 lines
4.1 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/integration-cli/cli"
|
|
"github.com/docker/docker/runconfig"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
// GH14530. Validates combinations of --net= with other options
|
|
|
|
// stringCheckPS is how the output of PS starts in order to validate that
|
|
// the command executed in a container did really run PS correctly.
|
|
const stringCheckPS = "PID USER"
|
|
|
|
type DockerCLINetmodeSuite struct {
|
|
ds *DockerSuite
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TearDownTest(ctx context.Context, c *testing.T) {
|
|
s.ds.TearDownTest(ctx, c)
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) OnTimeout(c *testing.T) {
|
|
s.ds.OnTimeout(c)
|
|
}
|
|
|
|
// DockerCmdWithFail executes a docker command that is supposed to fail and returns
|
|
// the output. If the command returns a Nil error, it will fail and stop the tests.
|
|
func dockerCmdWithFail(c *testing.T, args ...string) string {
|
|
c.Helper()
|
|
out, _, err := dockerCmdWithError(args...)
|
|
assert.Assert(c, err != nil, "%v", out)
|
|
return out
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestNetHostnameWithNetHost(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out := cli.DockerCmd(c, "run", "--net=host", "busybox", "ps").Stdout()
|
|
assert.Assert(c, is.Contains(out, stringCheckPS))
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestNetHostname(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out := cli.DockerCmd(c, "run", "-h=name", "busybox", "ps").Stdout()
|
|
assert.Assert(c, is.Contains(out, stringCheckPS))
|
|
out = cli.DockerCmd(c, "run", "-h=name", "--net=bridge", "busybox", "ps").Stdout()
|
|
assert.Assert(c, is.Contains(out, stringCheckPS))
|
|
out = cli.DockerCmd(c, "run", "-h=name", "--net=none", "busybox", "ps").Stdout()
|
|
assert.Assert(c, is.Contains(out, stringCheckPS))
|
|
out = dockerCmdWithFail(c, "run", "-h=name", "--net=container:other", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkHostname.Error()))
|
|
out = dockerCmdWithFail(c, "run", "--net=container", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, "invalid container format container:<name|id>"))
|
|
out = dockerCmdWithFail(c, "run", "--net=weird", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(strings.ToLower(out), "not found"))
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestConflictContainerNetworkAndLinks(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out := dockerCmdWithFail(c, "run", "--net=container:other", "--link=zip:zap", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictContainerNetworkAndLinks.Error()))
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestConflictContainerNetworkHostAndLinks(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out := dockerCmdWithFail(c, "run", "--net=host", "--link=zip:zap", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictHostNetworkAndLinks.Error()))
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestConflictNetworkModeNetHostAndOptions(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out := dockerCmdWithFail(c, "run", "--net=host", "--mac-address=92:d0:c6:0a:29:33", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictContainerNetworkAndMac.Error()))
|
|
}
|
|
|
|
func (s *DockerCLINetmodeSuite) TestConflictNetworkModeAndOptions(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out := dockerCmdWithFail(c, "run", "--net=container:other", "--dns=8.8.8.8", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkAndDNS.Error()))
|
|
out = dockerCmdWithFail(c, "run", "--net=container:other", "--add-host=name:8.8.8.8", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkHosts.Error()))
|
|
out = dockerCmdWithFail(c, "run", "--net=container:other", "-P", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkPublishPorts.Error()))
|
|
out = dockerCmdWithFail(c, "run", "--net=container:other", "-p", "8080", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkPublishPorts.Error()))
|
|
out = dockerCmdWithFail(c, "run", "--net=container:other", "--expose", "8000-9000", "busybox", "ps")
|
|
assert.Assert(c, is.Contains(out, runconfig.ErrConflictNetworkExposePorts.Error()))
|
|
}
|