89de943401
These consts were defined locally, but are now defined in golang.org/x/sys, so we can use those. Also added some documentation about how this function works, taking the description from the GetExitCodeProcess function (processthreadsapi.h) API reference: https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getexitcodeprocess > The GetExitCodeProcess function returns a valid error code defined by the > application only after the thread terminates. Therefore, an application should > not use `STILL_ACTIVE` (259) as an error code (`STILL_ACTIVE` is a macro for > `STATUS_PENDING` (minwinbase.h)). If a thread returns `STILL_ACTIVE` (259) as > an error code, then applications that test for that value could interpret it > to mean that the thread is still running, and continue to test for the > completion of the thread after the thread has terminated, which could put > the application into an infinite loop. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
pkg/ is a collection of utility packages used by the Moby project without being specific to its internals.
Utility packages are kept separate from the moby core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Moby organization, to facilitate re-use by other projects. However that is not the priority.
The directory pkg is named after the same directory in the camlistore project. Since Brad is a core
Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!
Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!