dilim/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-08-13 17:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
6566904016a35792c6bab172df5f5c57dacd7d7d
moby/daemon
History
Paweł Gronowski 1200f5e45c daemon: Fix panic in shutdown after daemon init fails 
When error during daemon initialization fails before the events manager
is created the daemon will panic instead of erroring out cleanly with
an actual error message.

```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x194fcec]

goroutine 1 [running, locked to thread]:
github.com/moby/moby/v2/daemon/events.(*Events).Close(...)
	/go/src/github.com/docker/docker/daemon/events/events.go:157
github.com/moby/moby/v2/daemon.(*Daemon).Shutdown(0x40001bf908, {0x2d664f0, 0x44c87e0})
	/go/src/github.com/docker/docker/daemon/daemon.go:1505 +0x3bc
github.com/moby/moby/v2/daemon.NewDaemon.func1()
	/go/src/github.com/docker/docker/daemon/daemon.go:907 +0x44
github.com/moby/moby/v2/daemon.NewDaemon({0x2d66560, 0x4000051c20}, 0x40004a6108, 0x40006fe810, 0x4000318700)
	/go/src/github.com/docker/docker/daemon/daemon.go:1371 +0x2130
github.com/moby/moby/v2/daemon/command.(*daemonCLI).start(0x4000051bd0, {0x2d664f0, 0x44c87e0})
	/go/src/github.com/docker/docker/daemon/command/daemon.go:264 +0xb90
github.com/moby/moby/v2/daemon/command.runDaemon(...)
	/go/src/github.com/docker/docker/daemon/command/docker_unix.go:13
github.com/moby/moby/v2/daemon/command.newDaemonCommand.func1(0x4000381808, {0x40006ac780?, 0x7?, 0x287f0b1?})
	/go/src/github.com/docker/docker/daemon/command/docker.go:48 +0xb0
github.com/spf13/cobra.(*Command).execute(0x4000381808, {0x4000050060, 0x4, 0x4})
	/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1015 +0x7d4
github.com/spf13/cobra.(*Command).ExecuteC(0x4000381808)
	/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1148 +0x350
github.com/spf13/cobra.(*Command).Execute(...)
	/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1071
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1064
github.com/moby/moby/v2/daemon/command.daemonRunner.Run({0x2d35440?}, {0x2d664f0, 0x44c87e0})
	/go/src/github.com/docker/docker/daemon/command/docker.go:97 +0x6c
main.main()
	/go/src/github.com/docker/docker/cmd/dockerd/main.go:35 +0x108
```

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2026-01-27 11:55:03 +01:00
..
builder
daemon: gofumpt
2026-01-24 17:16:05 +01:00
cluster
daemon/cluster/executor/container: rename vars that shadowed
2026-01-05 12:42:49 +01:00
command
loadDaemonCliConfig: explicitly set default host
2026-01-26 16:51:41 +01:00
config
reflect: Use TypeFor instead of TypeOf
2025-12-15 18:56:34 +01:00
container
modernize: Use range int
2025-12-15 18:56:34 +01:00
containerd
Merge pull request #51862 from thaJeztah/identity_version_gate
2026-01-26 17:08:02 +00:00
events
daemon: Fix panic in shutdown after daemon init fails
2026-01-27 11:55:03 +01:00
graphdriver
remove uses of deprecated go-archive consts
2025-12-19 17:51:03 +01:00
images
modernize: Use maps.Copy instead of for loops
2025-12-15 18:56:33 +01:00
initlayer
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
internal
daemon: gofumpt
2026-01-24 17:16:05 +01:00
libnetwork
daemon: gofumpt
2026-01-24 17:16:05 +01:00
links
modernize: Use b.Loop (introduced in Go 1.24)
2025-12-15 18:56:33 +01:00
listeners
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logger
fix: goroutine leak in TestRingLogger
2026-01-16 16:22:03 +05:30
names
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
network
api/t/network: represent MAC addrs as byte slices
2025-10-30 17:11:38 -04:00
pkg
daemon/pkg/opts: remove unused ParseHost
2026-01-26 16:51:48 +01:00
server
Merge pull request #51862 from thaJeztah/identity_version_gate
2026-01-26 17:08:02 +00:00
snapshotter
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
stats
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
testdata
Improve CPU usage parsing and error reporting
2025-04-07 16:19:02 +02:00
volume
daemon/volume/mounts: extract validation for extra fields
2026-01-21 12:20:30 +01:00
apparmor_default_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
apparmor_default.go
profiles/apparmor, seccomp: migrate to separate module
2025-07-22 18:48:39 +02:00
archive_tarcopyoptions_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
archive_tarcopyoptions.go
daemon: ContainerExtractToDir: make AllowOverwriteDirWithFile opt-in
2025-07-13 16:37:36 +02:00
archive_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
archive_windows.go
remove uses of deprecated go-archive consts
2025-12-19 17:51:03 +01:00
archive.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
attach.go
api/pkg/stdcopy: move stdWriter to daemon/internal
2025-10-09 20:13:26 -04:00
auth.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
build.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
cdi.go
cdi: resolve symlinks
2025-12-02 02:30:14 +09:00
changes.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
checkpoint.go
api/types/checkpoint: move checkpoint options to client
2025-09-05 10:20:06 +02:00
cluster.go
daemon: report IPAM status for Swarm networks
2025-09-11 15:25:14 -04:00
commit.go
modernize: Use maps.Copy instead of for loops
2025-12-15 18:56:33 +01:00
configs.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
container_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
container_operations_test.go
Allow configured address with no configured subnet
2025-11-24 14:14:27 +00:00
container_operations_unix.go
api/types/network: use netip types as appropriate
2025-10-03 21:39:14 +02:00
container_operations_windows.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
container_operations.go
fix grammar: user defined / user specified -> user-(defined|specified)
2026-01-19 13:43:06 +01:00
container_unix_test.go
api: move container port type to network package
2025-10-03 17:30:42 -05:00
container_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
container.go
daemon: disallow container port 0
2025-12-11 11:07:42 +01:00
containerfs_linux_test.go
pkg/fileutils: move ReadSymlinkedDirectory internal to daemon
2025-07-29 11:16:25 +02:00
containerfs_linux.go
chore: use errors.Join instead of github.com/hashicorp/go-multierror
2025-08-08 19:19:21 +02:00
content.go
fix duplicate import, and force consistent alias for bolt
2025-04-22 11:31:10 +02:00
create_unix.go
Daemon.createContainerOSSpecificSettings - remove redundant param
2025-11-16 18:25:42 +00:00
create_windows.go
Daemon.createContainerOSSpecificSettings - remove redundant param
2025-11-16 18:25:42 +00:00
create.go
NRI: add ContainerCreate hook, allow env-var adjustments
2025-12-10 10:30:44 +00:00
daemon_linux_test.go
internal/testutils: merge with internal/testutil
2025-09-08 10:08:35 +02:00
daemon_linux.go
modernize: Use slices.Contains
2025-12-15 18:56:34 +01:00
daemon_test.go
daemon: disallow container port 0
2025-12-11 11:07:42 +01:00
daemon_unix_test.go
daemon: use errdefs instead of string-matching in some places
2025-10-25 16:13:30 +02:00
daemon_unix.go
vendor: github.com/opencontainers/runtime-spec v1.3.0
2025-12-18 19:55:56 +01:00
daemon_unsupported.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
daemon_windows_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
daemon_windows.go
Move call to Daemon.registerLinks out of Daemon.setHostConfig
2025-11-16 18:20:12 +00:00
daemon.go
daemon: gofumpt
2026-01-24 17:16:05 +01:00
debugtrap_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
debugtrap_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
debugtrap_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
delete_test.go
daemon/container: remove NewState() constructor
2025-09-19 15:33:36 +01:00
delete.go
api/types/container: make ContainerState a concrete type
2025-11-10 16:08:12 +01:00
dependency.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
devices_amd_linux.go
Map nvidia --gpus request to CDI device requests
2026-01-20 13:53:12 +01:00
devices_nvidia_linux.go
Map nvidia --gpus request to CDI device requests
2026-01-20 13:53:12 +01:00
devices.go
Use Debug instead of Debugf for device request logging
2026-01-19 14:10:12 +01:00
disk_usage.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
errors_test.go
…
errors.go
fix grammar: user defined / user specified -> user-(defined|specified)
2026-01-19 13:43:06 +01:00
events_test.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
events.go
daemon: inline copyAttributes utilty
2026-01-05 12:42:49 +01:00
exec_linux_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
export.go
remove uses of deprecated go-archive consts
2025-12-19 17:51:03 +01:00
health_test.go
explicitly access Container.State.Health.Health
2025-09-19 15:33:36 +01:00
health.go
api/types/container: make HealthStatus a concrete type
2025-11-10 16:08:15 +01:00
hosts_test.go
image: pull/load/save attestation manifest and signatures with image
2025-11-12 07:53:46 -08:00
hosts.go
image: pull/load/save attestation manifest and signatures with image
2025-11-12 07:53:46 -08:00
id.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
image_service.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
image_store_choice_test.go
daemon: Fix image store choice priority for prior graphdriver state
2025-11-13 10:05:49 +01:00
image_store_choice.go
daemon: Fix image store choice priority for prior graphdriver state
2025-11-13 10:05:49 +01:00
info_unix_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
info_unix.go
modernize: Use strings.CutSuffix
2025-12-15 18:56:34 +01:00
info_windows.go
api/types: move Version to api/types/system
2025-10-31 02:09:38 +01:00
info.go
NRI: include in API Info response
2025-12-15 10:36:05 +00:00
inspect_linux.go
api/types/container: merge InspectResponse and ContainerJSONBase
2025-08-26 20:18:57 +02:00
inspect_test.go
daemon: Daemon.getInspectData: move migration code to router
2025-10-21 09:15:18 +02:00
inspect_windows.go
api/types/container: merge InspectResponse and ContainerJSONBase
2025-08-26 20:18:57 +02:00
inspect.go
modernize: Use maps.Copy instead of for loops
2025-12-15 18:56:33 +01:00
keys_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
keys.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
kill.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
licensing_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
licensing.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
links.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list_test.go
modernize: Use slices.Contains
2025-12-15 18:56:34 +01:00
list_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list.go
modernize: Use min built-in
2025-12-15 18:56:34 +01:00
logdrivers_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logdrivers_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logs_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
logs.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
migration_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
migration.go
daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend
2025-10-05 13:41:22 +02:00
monitor.go
api/types/container: make ContainerState a concrete type
2025-11-10 16:08:12 +01:00
mounts.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
names.go
modernize: Use range int
2025-12-15 18:56:34 +01:00
network_test.go
api/types/network: use netip types as appropriate
2025-10-03 21:39:14 +02:00
network_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
network.go
modernize: Use slices.Contains
2025-12-15 18:56:34 +01:00
oci_linux_test.go
daemon: Simplify slices.Contains usage
2025-12-16 13:31:33 +01:00
oci_linux.go
daemon: Simplify slices.Contains usage
2025-12-16 13:31:33 +01:00
oci_opts.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_utils.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_windows_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_windows.go
daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend
2025-10-05 13:41:22 +02:00
pause.go
daemon: use errdefs instead of string-matching in some places
2025-10-25 16:13:30 +02:00
prune.go
client: singularize prune methods
2025-11-05 15:48:02 +01:00
reload_test.go
modernize: Use range int
2025-12-15 18:56:34 +01:00
reload_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
reload_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
reload.go
NRI: make config reloadable
2025-12-15 13:59:09 +00:00
rename.go
daemon: improve validation for container rename
2025-10-29 18:42:36 +01:00
resize_test.go
daemon: use t.Context() in tests
2025-09-25 22:53:48 +02:00
resize.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
restart.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
runtime_unix_test.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
runtime_unix.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
runtime_windows.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
seccomp_linux_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
seccomp_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
seccomp_unsupported.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
secrets.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
start_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
start_notlinux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
start_unix.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
start_windows.go
Fix custom runtimes handling on Windows
2025-08-08 21:41:17 +02:00
start.go
daemon/container: remove State.ExitCode() method
2025-09-19 15:33:36 +01:00
stats_collector.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
stats_unix_test.go
Refactor CPU usage stats test to use go:embed
2025-05-16 10:23:49 -04:00
stats_unix.go
daemon: gofumpt
2026-01-24 17:16:05 +01:00
stats_windows.go
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
stats.go
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
stop.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
top_unix_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
top_unix.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
top_windows.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
unpause.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
update_linux_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
update_linux.go
remove support for deprecated kernel memory limit
2025-09-16 13:08:36 +02:00
update_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
update.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
volumes_linux_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
volumes_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_unit_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes.go
daemon: rename vars that shadowed imports
2026-01-21 16:36:05 +01:00
wait.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
workdir.go
update github links to moby/moby
2025-08-01 01:48:55 +02:00