Files
moby/client/utils.go
Sebastiaan van Stijn 9295e2cd84 client: fix race in cancelReadCloser
```
=== RUN   TestNewCancelReadCloserRace
==================
WARNING: DATA RACE
Read at 0x00c0003cc018 by goroutine 74:
  github.com/moby/moby/client.(*cancelReadCloser).Close()
      /go/src/github.com/docker/docker/client/utils.go:152 +0x30
  github.com/moby/moby/client.newCancelReadCloser.func1()
      /go/src/github.com/docker/docker/client/utils.go:139 +0x2c

Previous write at 0x00c0003cc018 by goroutine 8:
  github.com/moby/moby/client.newCancelReadCloser()
      /go/src/github.com/docker/docker/client/utils.go:139 +0x1d8
  github.com/moby/moby/client.TestNewCancelReadCloserRace()
      /go/src/github.com/docker/docker/client/utils_test.go:67 +0x40
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1934 +0x164
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1997 +0x3c

Goroutine 74 (running) created at:
  context.(*afterFuncCtx).cancel.func1()
      /usr/local/go/src/context/context.go:358 +0x40
  sync.(*Once).doSlow()
      /usr/local/go/src/sync/once.go:78 +0x94
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:69 +0x40
  context.(*afterFuncCtx).cancel()
      /usr/local/go/src/context/context.go:357 +0xb8
  context.(*cancelCtx).propagateCancel()
      /usr/local/go/src/context/context.go:486 +0x1d8
  context.AfterFunc()
      /usr/local/go/src/context/context.go:329 +0xcc
  github.com/moby/moby/client.newCancelReadCloser()
      /go/src/github.com/docker/docker/client/utils.go:139 +0x1c8
  github.com/moby/moby/client.TestNewCancelReadCloserRace()
      /go/src/github.com/docker/docker/client/utils_test.go:67 +0x40
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1934 +0x164
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1997 +0x3c

Goroutine 8 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1997 +0x6e0
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:2477 +0x74
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1934 +0x164
  testing.runTests()
      /usr/local/go/src/testing/testing.go:2475 +0x734
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:2337 +0xaf4
  main.main()
      _testmain.go:651 +0x100
==================
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x69c11c]

goroutine 246 [running]:
github.com/moby/moby/client.(*cancelReadCloser).Close(0xc00070ab80)
	/go/src/github.com/docker/docker/client/utils.go:152 +0x3c
github.com/moby/moby/client.newCancelReadCloser.func1()
	/go/src/github.com/docker/docker/client/utils.go:139 +0x30
created by context.(*afterFuncCtx).cancel.func1 in goroutine 7
	/usr/local/go/src/context/context.go:358 +0x44
exit status 2
FAIL	github.com/moby/moby/client	0.035s
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2026-04-01 13:57:15 +02:00

155 lines
4.2 KiB
Go

package client
import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
"strconv"
"strings"
"sync"
cerrdefs "github.com/containerd/errdefs"
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
)
type emptyIDError string
func (e emptyIDError) InvalidParameter() {}
func (e emptyIDError) Error() string {
return "invalid " + string(e) + " name or ID: value is empty"
}
// trimID trims the given object-ID / name, returning an error if it's empty.
func trimID(objType, id string) (string, error) {
id = strings.TrimSpace(id)
if id == "" {
return "", emptyIDError(objType)
}
return id, nil
}
// parseAPIVersion checks v to be a well-formed ("<major>.<minor>")
// API version. It returns an error if the value is empty or does not
// have the correct format, but does not validate if the API version is
// within the supported range ([MinAPIVersion] <= v <= [MaxAPIVersion]).
//
// It returns version after normalizing, or an error if validation failed.
func parseAPIVersion(version string) (string, error) {
if strings.TrimPrefix(strings.TrimSpace(version), "v") == "" {
return "", cerrdefs.ErrInvalidArgument.WithMessage("value is empty")
}
major, minor, err := parseMajorMinor(version)
if err != nil {
return "", err
}
return fmt.Sprintf("%d.%d", major, minor), nil
}
// parseMajorMinor is a helper for parseAPIVersion.
func parseMajorMinor(v string) (major, minor int, _ error) {
if strings.HasPrefix(v, "v") {
return 0, 0, cerrdefs.ErrInvalidArgument.WithMessage("must be formatted <major>.<minor>")
}
if strings.TrimSpace(v) == "" {
return 0, 0, cerrdefs.ErrInvalidArgument.WithMessage("value is empty")
}
majVer, minVer, ok := strings.Cut(v, ".")
if !ok {
return 0, 0, cerrdefs.ErrInvalidArgument.WithMessage("must be formatted <major>.<minor>")
}
major, err := strconv.Atoi(majVer)
if err != nil {
return 0, 0, cerrdefs.ErrInvalidArgument.WithMessage("invalid major version: must be formatted <major>.<minor>")
}
minor, err = strconv.Atoi(minVer)
if err != nil {
return 0, 0, cerrdefs.ErrInvalidArgument.WithMessage("invalid minor version: must be formatted <major>.<minor>")
}
return major, minor, nil
}
// encodePlatforms marshals the given platform(s) to JSON format, to
// be used for query-parameters for filtering / selecting platforms.
func encodePlatforms(platform ...ocispec.Platform) ([]string, error) {
if len(platform) == 0 {
return []string{}, nil
}
if len(platform) == 1 {
p, err := encodePlatform(&platform[0])
if err != nil {
return nil, err
}
return []string{p}, nil
}
seen := make(map[string]struct{}, len(platform))
out := make([]string, 0, len(platform))
for i := range platform {
p, err := encodePlatform(&platform[i])
if err != nil {
return nil, err
}
if _, ok := seen[p]; !ok {
out = append(out, p)
seen[p] = struct{}{}
}
}
return out, nil
}
// encodePlatform marshals the given platform to JSON format, to
// be used for query-parameters for filtering / selecting platforms. It
// is used as a helper for encodePlatforms,
func encodePlatform(platform *ocispec.Platform) (string, error) {
p, err := json.Marshal(platform)
if err != nil {
return "", fmt.Errorf("%w: invalid platform: %v", cerrdefs.ErrInvalidArgument, err)
}
return string(p), nil
}
func decodeWithRaw[T any](resp *http.Response, out *T) (raw json.RawMessage, _ error) {
if resp == nil || resp.Body == nil {
return nil, errors.New("empty response")
}
defer ensureReaderClosed(resp)
var buf bytes.Buffer
tr := io.TeeReader(resp.Body, &buf)
err := json.NewDecoder(tr).Decode(out)
if err != nil {
return nil, err
}
return buf.Bytes(), nil
}
// newCancelReadCloser wraps rc so it's automatically closed when ctx is canceled.
// Close is idempotent and returns the first error from rc.Close.
func newCancelReadCloser(ctx context.Context, rc io.ReadCloser) io.ReadCloser {
crc := &cancelReadCloser{
rc: rc,
close: sync.OnceValue(rc.Close),
}
crc.stop = context.AfterFunc(ctx, func() { _ = crc.close() })
return crc
}
type cancelReadCloser struct {
rc io.ReadCloser
close func() error
stop func() bool
}
func (c *cancelReadCloser) Read(p []byte) (int, error) { return c.rc.Read(p) }
func (c *cancelReadCloser) Close() error {
c.stop() // unregister AfterFunc
return c.close()
}