mirror of
https://github.com/moby/moby.git
synced 2026-07-10 00:28:51 +00:00
4cd5c2b643
cross-compiling for arm/v5 was failing;
#56 84.12 /usr/bin/arm-linux-gnueabi-clang -marm -o $WORK/b001/exe/a.out -Wl,--export-dynamic-symbol=_cgo_panic -Wl,--export-dynamic-symbol=_cgo_topofstack -Wl,--export-dynamic-symbol=crosscall2 -Qunused-arguments -Wl,--compress-debug-sections=zlib /tmp/go-link-759578347/go.o /tmp/go-link-759578347/000000.o /tmp/go-link-759578347/000001.o /tmp/go-link-759578347/000002.o /tmp/go-link-759578347/000003.o /tmp/go-link-759578347/000004.o /tmp/go-link-759578347/000005.o /tmp/go-link-759578347/000006.o /tmp/go-link-759578347/000007.o /tmp/go-link-759578347/000008.o /tmp/go-link-759578347/000009.o /tmp/go-link-759578347/000010.o /tmp/go-link-759578347/000011.o /tmp/go-link-759578347/000012.o /tmp/go-link-759578347/000013.o /tmp/go-link-759578347/000014.o /tmp/go-link-759578347/000015.o /tmp/go-link-759578347/000016.o /tmp/go-link-759578347/000017.o /tmp/go-link-759578347/000018.o -O2 -g -O2 -g -O2 -g -lpthread -O2 -g -no-pie -static
#56 84.12 ld.lld: error: undefined symbol: __atomic_load_4
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(_cgo_wait_runtime_init_done)
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(_cgo_wait_runtime_init_done)
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(_cgo_wait_runtime_init_done)
#56 84.12 >>> referenced 2 more times
#56 84.12
#56 84.12 ld.lld: error: undefined symbol: __atomic_store_4
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(_cgo_wait_runtime_init_done)
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(x_cgo_notify_runtime_init_done)
#56 84.12 >>> referenced by gcc_libinit.c
#56 84.12 >>> /tmp/go-link-759578347/000009.o:(x_cgo_set_context_function)
#56 84.12 clang: error: linker command failed with exit code 1 (use -v to see invocation)
From discussion on GitHub;
https://github.com/moby/moby/pull/46982#issuecomment-2206992611
The arm/v5 build failure looks to be due to libatomic not being included
in the link. For reasons probably buried in mailing list archives,
[gcc](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81358) and clang don't
bother to implicitly auto-link libatomic. This is not a big deal on many
modern platforms with atomic intrinsics as the compiler generates inline
instruction sequences, avoiding any libcalls into libatomic. ARMv5 is not
one of those platforms: all atomic operations require a libcall.
In theory, adding `CGO_LDFLAGS=-latomic` should fix arm/v5 builds.
While it could be argued that cgo should automatically link against
libatomic in the same way that it automatically links against libpthread,
the Go maintainers would have a valid counter-argument that it should be
the C toolchain's responsibility to link against libatomic automatically,
just like it does with libgcc or compiler-rt.
Co-authored-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Cory Snider <csnider@mirantis.com>
101 lines
3.2 KiB
Bash
101 lines
3.2 KiB
Bash
#!/usr/bin/env bash
|
|
set -e
|
|
|
|
# a helper to provide ".exe" when it's appropriate
|
|
binary_extension() {
|
|
if [ "$(go env GOOS)" = 'windows' ]; then
|
|
echo -n '.exe'
|
|
fi
|
|
}
|
|
|
|
BINARY_EXTENSION="$(binary_extension)"
|
|
BINARY_FULLNAME="$BINARY_NAME$BINARY_EXTENSION"
|
|
|
|
source "${MAKEDIR}/.go-autogen"
|
|
|
|
(
|
|
export GOGC=${DOCKER_BUILD_GOGC:-1000}
|
|
|
|
if [ "$(go env GOOS)/$(go env GOARCH)" != "$(go env GOHOSTOS)/$(go env GOHOSTARCH)" ]; then
|
|
# must be cross-compiling!
|
|
if [ "$(go env GOOS)/$(go env GOARCH)" = "linux/arm" ]; then
|
|
# specify name of the target ARM architecture
|
|
case "$(go env GOARM)" in
|
|
5)
|
|
export CGO_CFLAGS="-march=armv5t"
|
|
export CGO_CXXFLAGS="-march=armv5t"
|
|
;;
|
|
6)
|
|
export CGO_CFLAGS="-march=armv6"
|
|
export CGO_CXXFLAGS="-march=armv6"
|
|
;;
|
|
7)
|
|
export CGO_CFLAGS="-march=armv7-a"
|
|
export CGO_CXXFLAGS="-march=armv7-a"
|
|
;;
|
|
esac
|
|
fi
|
|
fi
|
|
|
|
# -buildmode=pie is not supported on Windows arm64 and Linux mips*, ppc64be
|
|
# https://github.com/golang/go/blob/go1.19.4/src/cmd/internal/sys/supported.go#L125-L132
|
|
if ! [ "$DOCKER_STATIC" = "1" ]; then
|
|
# -buildmode=pie not supported when -race is enabled
|
|
if [[ " $BUILDFLAGS " != *" -race "* ]]; then
|
|
case "$(go env GOOS)/$(go env GOARCH)" in
|
|
windows/arm64 | linux/mips* | linux/ppc64) ;;
|
|
*)
|
|
BUILDFLAGS+=("-buildmode=pie")
|
|
;;
|
|
esac
|
|
fi
|
|
fi
|
|
|
|
# XXX: Disable netgo on Windows and use Window's system resolver instead.
|
|
#
|
|
# go1.19 and newer added support for netgo on Windows (https://go.dev/doc/go1.19#net),
|
|
# which won't ask Windows for DNS results, and hence may be ignoring
|
|
# custom "C:\Windows\System32\drivers\etc\hosts".
|
|
# See https://github.com/moby/moby/issues/45251#issuecomment-1561001817
|
|
# https://github.com/moby/moby/issues/45251, and
|
|
# https://go-review.googlesource.com/c/go/+/467335
|
|
if [ "$(go env GOOS)" = "windows" ]; then
|
|
BUILDFLAGS=("${BUILDFLAGS[@]/netgo/}")
|
|
fi
|
|
|
|
# only necessary for non-sandboxed invocation where TARGETPLATFORM is empty
|
|
PLATFORM_NAME=$TARGETPLATFORM
|
|
if [ -z "$PLATFORM_NAME" ]; then
|
|
PLATFORM_NAME="$(go env GOOS)/$(go env GOARCH)"
|
|
if [ -n "$(go env GOARM)" ]; then
|
|
PLATFORM_NAME+="/v$(go env GOARM)"
|
|
elif [ -n "$(go env GOAMD64)" ] && [ "$(go env GOAMD64)" != "v1" ]; then
|
|
PLATFORM_NAME+="/$(go env GOAMD64)"
|
|
fi
|
|
fi
|
|
|
|
if [ -n "${DOCKER_DEBUG}" ]; then
|
|
GCFLAGS="all=-N -l"
|
|
fi
|
|
|
|
if [ "$(go env GOARCH)" = "arm" ] && [ "$(go env GOARM)" = "5" ]; then
|
|
# cross-compiling for arm/v5 fails on go1.22; a fix is included for this
|
|
# in go1.23 (https://github.com/golang/go/issues/65290), but for go1.22
|
|
# we can set the correct option manually.
|
|
CGO_CFLAGS+=" -Wno-atomic-alignment"
|
|
export CGO_CFLAGS
|
|
|
|
# Make sure libatomic is included on arm/v5, because clang does not auto-link it.
|
|
# see https://github.com/moby/moby/pull/46982#issuecomment-2206992611
|
|
export CGO_LDFLAGS="-latomic"
|
|
fi
|
|
|
|
echo "Building $([ "$DOCKER_STATIC" = "1" ] && echo "static" || echo "dynamic") $DEST/$BINARY_FULLNAME ($PLATFORM_NAME)..."
|
|
if [ -n "$DOCKER_DEBUG" ]; then
|
|
set -x
|
|
fi
|
|
./hack/with-go-mod.sh go build -mod=vendor -modfile=vendor.mod -o "$DEST/$BINARY_FULLNAME" "${BUILDFLAGS[@]}" -ldflags "$LDFLAGS $LDFLAGS_STATIC $DOCKER_LDFLAGS" -gcflags="${GCFLAGS}" "$GO_PACKAGE"
|
|
)
|
|
|
|
echo "Created binary: $DEST/$BINARY_FULLNAME"
|