Cory Snider b62445871e libnet/ipam: fix racy, flaky unit test ...

TestRequestReleaseAddressDuplicate gets flagged by go test -race because
the same err variable inside the test is assigned to from multiple
goroutines without synchronization, which obscures whether or not there
are any data races in the code under test.

Trouble is, the test _depends on_ the data race to exit the loop if an
error occurs inside a spawned goroutine. And the test contains a logical
concurrency bug (not flagged by the Go race detector) which can result
in false-positive test failures. Because a release operation is logged
after the IP is released, the other goroutine could reacquire the
address and log that it was reacquired before the release is logged.

Fix up the test so it is no longer subject to data races or
false-positive test failures, i.e. flakes.

Signed-off-by: Cory Snider <csnider@mirantis.com>

2023-02-16 18:00:31 -05:00

..

allocator_test.go

libnet/ipam: fix racy, flaky unit test

2023-02-16 18:00:31 -05:00

allocator.go

libnet/ipam: stop eagerly stringifying debug logs

2023-02-08 16:54:27 -05:00

parallel_test.go

libnetwork: drop DatastoreConfig discovery type

2023-01-27 11:47:43 -05:00

structures.go

libnetwork/ipam: skip Destroy()ing bitseq.Handle values

2023-01-27 11:47:43 -05:00

utils.go

Fix libnetwork imports

2021-06-01 21:51:23 +00:00