Migrate the configuration using `golangci-lint migrate` and hand-edit to
minimize the textual diff with the v1 configuration. Exclude very noisy
linter rules that are more trouble than they are worth on a maintenance
branch. Fix the lints including duplicate imports, Yoda conditions and
WriteString(fmt.Fprintf(...)) that are obviously semantically equivalent
by inspection. Disable false-positive gosec lints where appropriate.
Also fix (*loggerutils.sharedTempFileConverter).Do() to compare file
modification times with (time.Time).Equal(). While technically not
semantically equivalent to the == operator, in practice it is equivalent
when comparing the modification times of two Stat()'ed files since
neither timestamp will have a monotonic component.
Signed-off-by: Cory Snider <csnider@mirantis.com>
Cory Snider
c393ec6ca5